Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme the julia> prompt in the julia-repl language #1641

Merged
merged 1 commit into from
Jul 16, 2021
Merged

Theme the julia> prompt in the julia-repl language #1641

merged 1 commit into from
Jul 16, 2021

Conversation

fredrikekre
Copy link
Member

Theme the julia> prompt in the julia-repl language as green using the same color as the ANSI color green for respective theme.

@fredrikekre
Copy link
Member Author

Screenshot from 2021-07-09 12-32-31
Screenshot from 2021-07-09 12-32-50

@kimikage
Copy link
Contributor

kimikage commented Jul 9, 2021

We could use the variable $ansi-green by writing the patch in documenter-{dark|light}.scss instead of documenter/_patches.scss. Although I can't say that is generally a good practice, I personally prefer the style with fewer hard-coded constants.

@fredrikekre
Theme the julia> prompt in the julia-repl language
d32edcd 
as green using the same color as the ANSI color green
for respective theme.
@fredrikekre
Copy link
Member Author

Good idea, I moved it.

@fredrikekre fredrikekre requested a review from mortenpi July 14, 2021 11:56
@fredrikekre fredrikekre added the Format: HTML Related to the default HTML output label Jul 14, 2021
@fredrikekre fredrikekre merged commit 797a96f into master Jul 16, 2021
@fredrikekre fredrikekre deleted the fe/prompt branch July 16, 2021 13:40
@kimikage kimikage mentioned this pull request Jul 17, 2021
Closed
@mortenpi mortenpi added this to the 0.27.4 milestone Jul 19, 2021
@fredrikekre
Copy link
Member Author

Prompts have their own class now: highlightjs/highlight.js#3490

@mortenpi
Copy link
Member

Prompts have their own class now: highlightjs/highlight.js#3490

I noticed that in #1846. Should we remove the override?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortenpi mortenpi Awaiting requested review from mortenpi

Assignees
No one assigned
Labels
Format: HTML Related to the default HTML output Type: Enhancement
Projects
None yet
Milestone
0.27.4
Development

Successfully merging this pull request may close these issues.
3 participants
@fredrikekre @kimikage @mortenpi