Display Documenter version in document build info. #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekre
force-pushed
the
fe/documenter-version
branch
from
4084050 to
172dfa3
Compare
mortenpi
added
Format: HTML
mortenpi
approved these changes
Jun 21, 2021
There was a problem hiding this comment.
I'm happy with this, but would there also be a way to detect if you're running a modified version of Documenter (e.g. a specific commit from master etc)? Even something that would just detect if it is a tagged version or not would be nice (e.g. outputting v0.27.3 (untagged)).
That said, if you can't think of an easy way to do this, I am more than happy to keep it as is.
|
That's a bit tricky. A user will generally not have the git repository of Documenter (even if you add by branch/commit) so you would have to try and find some more information in the users manifest which to me doesn't seems worth it. |
KristofferC
reviewed
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.