Use SVG for brand icons and FA icon for source link #1475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekre
reviewed
Nov 11, 2020
|
For recompiling the CSS (also applies to #1476), please use DocumenterTools (it's not obvious, we really need to document this) -- it makes sure that the correct code formatting is used for the resulting CSS etc.: using DocumenterTools: Themes
Themes.compile_native_themes()The only thing you need to make sure is that your local Documenter clone is a dev. dependency of the environment where you also installed DocumenterTools. |
mortenpi
added
Format: HTML
|
Yeah might useful to add this to the contributing page in the docs |
friggog
force-pushed
the
svg-brand-icons
branch
from
af52823 to
725a1db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses inline SVG icons for repo brands (GitHub, GitLab etc) which allows for ADO logo as well.
Remove FA brands font as a result.
Had to update the stylesheet - not sure I've done this in the right/best way, also recompiling causes complete changes to the CSS, not sure if there is a preferred way to do this?
Also changed the source link for each function to use the FA code icon which I think looks nicer?
