Do not declare writers <: Plugin #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the HTML, Markdown and LaTeX objects can be passed as positional arguments to makedocs, but they do not have any effect, effectively failing silently. With this, they can only be passed via the format keyword. The Writer abstract type is currently not part of the public API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
HTML,MarkdownandLaTeXobjects can be passed as positional arguments tomakedocs, but they do not have any effect, effectively failing silently. With this patch, they can only be passed via theformatkeyword.The
Writerabstract type is currently not part of the public API.Fix #1046