-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a new HTML front end with Bulma #1043
Conversation
margin-bottom: auto; | ||
&::before { | ||
@include font-awesome; | ||
content: "\f054"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you make it specific to levels > 1, then you can put something like
margin-left: -1em;
margin-right: 0;
background: $sidebar-background;
here to get what I showed on Slack.
Hello! Just came here to add exactly the same comment as @cormullion , but of course cormullion being cormullion did it much before me! I also thing the warning boxes should use a bit more saturated colors. It makes it easier on the eyes. Also, a light gray background over the text in the white version would help (as at the moment you cant really tell when the block ends) |
Good idea, although I need to think about how to implement it (the logo and the theme are not technically related to each other). Do you have an SVG of the inverted logo by any chance though? |
I left the colors slightly more saturated than what @cormullion suggested at the moment: I feel that they are dimmed enough, yet nicely retain some colorfulness. Overall, I think I managed to take care of most color issues now (not the logo yet though). Feedback most welcome though. Here is the latest demo:
|
Lower contrast is great now. (de gustibus non est disputandum) 😅 |
On the Settings menu, is that "generated by Documenter... " the date of the document's generation (fixing #724 yay!), or something to do with the settings? |
That's when the document was generated (you can hover to see the time too). I put it into the settings dialog since I couldn't really figure out how to make it look readable and unobtrusive at the same time in the footer. |
Perhaps you could include the document name there, so that it's clear that it's this specific document, not the Documenter HTML theme, or whatever? |
* Remove internals page -- we have collapsed sidebar items now * Add a showcase page
In case anyone is brave enough to review any of this, then now would be the time. I will appreciate any feedback 🙂 Generally, I think it's in good enough shape to be merged (we'll probably have some fixes in follow-up PRs), but I'll leave it open for a few more days. |
Hmm, might be better to go back to Roboto Mono then, but have a slightly better fallback behavior than before: font-family: 'Roboto Mono', 'SFMono-Regular', 'Menlo', 'Consolas', 'Liberation Mono', 'DejaVu Sans Mono', monospace; Or, alternatively, we could try to target the OS default monospace fonts: font-family: 'SFMono-Regular', 'Menlo', 'Consolas', 'Liberation Mono', 'DejaVu Sans Mono', monospace; I don't really have a very strong opinion myself. The alignment problem of #618 is pretty much unsolvable, and not really a problem for the Julia manual anyway, so we can just focus on which one looks better. |
Uses #222 now for main text, like the current manual.
* Use Roboto Mono + sytem fallbacks for monospace * Update sans-serif fallbacks * Make sure the dark theme uses same fonts
Maybe a different bullet, i.e. one that is not the same as Julia's comment character and Markdown headers, would be better? ;-) BTW: This looks great 👍 |
It seems that syntax highlighting is broken: from https://mortenpi.eu/gsoc2019-mockups/bulma/v7/documenter/man/syntax/#@ref-link-1 This happens if:
Switching to the dark theme and then switching back to the default gives me: |
@tkf Do you see the same issue with a newer version too?
|
Looks good to me. I didn't realize that the link in the OP was an older version. |
I personally actually like that it mirrors the Markdown syntax since you create those headings literally with a Here are the latest builds (also updated the OP):
|
I see your point and I certainly could get used to it. It just sticks out a bit especially if juxtaposed with other bulleted lists (see below) and like @cormullion, I first interpreted it as a rendering error. |
I didn't even realize the hashes were intentional; I also thought they were an error. |
I merged this so that any follow-up changes could be made in separate, more manageable PRs. This does not mean that any of the style etc. is final yet -- I opened a dedicated issue to collect feedback: #1091. |
Demo:
TODO:
<div>
; won't fix now, but might revisit the use of bulma-dashboard)note
admonition styling (close Style info admonitions correctly #1030)Close #626, close #722. Also addresses #981,
#618.