Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sitename missing from makedocs docstring #883

Closed
tpapp opened this issue Nov 7, 2018 · 3 comments
Closed

sitename missing from makedocs docstring #883

tpapp opened this issue Nov 7, 2018 · 3 comments

Comments

@tpapp
Copy link
Contributor

tpapp commented Nov 7, 2018

I think makedocs(sitename = ...) is still required, but is no longer mentioned at
https://juliadocs.github.io/Documenter.jl/dev/lib/public/

@mortenpi
Copy link
Member

Hmm. It is required for the (default) HTML, used by LaTeX, but the build should finish if it is unset and completely unused by the Markdown output. We should either make it Writer-specific or mandatory for all writers -- not sure which is the better option though.

@tpapp
Copy link
Contributor Author

tpapp commented Apr 2, 2019

Friendly bump --- until a decision is reached, would it make sense to mention sitename in the docstring of makedocs? It is still used and even tested for.

@fredrikekre
Copy link
Member

Yea, please make a PR.

mortenpi pushed a commit that referenced this issue Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants