New Search Modal UI #2202

Hetarth02 · 2023-08-06T12:49:09Z

Edit by @mortenpi: added the TODO list:
Last Edit by @Hetarth02 : 2023-08-20:

Have the modal be full size all the time on desktop too.
Distinguish the search-result-title somehow (font-weigth: 600).
Have the search-result-title for code items (like function names and such; anything except Page, Section) in monospace (but make font a bit smaller, to match what we do in main body).
Add section titles to search results (add to the bottom near the URL somehow).
Fix the bug with some URLs incorrectly being cut off (search "parametric")
Remove / replace the "No recent searches!" string, as it's confusing. Replace with Type something to get started.
Get rid of the search input box (or make it inactive, with click triggering the search modal)

Edit by @mortenpi: close #1437, close #2147

Well, the search UI has had a complete overhaul, with a fresh new modal UI s mentioned in Issue #2147 with better context for search results and a filter mechanism to remove those pesky unwanted results.

Here is the full demo,

Recording.2023-08-06.180832_compress.mp4

Additionally, the modal is mobile responsive!

Search will now look like this,

Light Mode:

Without Filter:

With Filter:

Dark Mode:

Without Filter:

With Filter:

~~Since these we very small fixes, I did them while we are updating the search UI altogether.~~
~~- #2215 Removed some extra space between navbar header icons.~~

~~- #2103: Fixed, docstring collapse/expand icon not changing when clicking rapidly. Now click all you want!~~

- Fixed the collapse/expand issue when clicked repeatedly - Remove extra space from the navbar header icons

Hetarth02 · 2023-08-06T13:00:40Z

I think the only thing to do now would be,

To add a search icon/input box in the navbar
Remove the search input from the sidebar

mortenpi · 2023-08-10T14:53:56Z

Awesome! A couple of thoughts:

Let's reduce the top and bottom margins. Something on the order of 1-3rem should be good.
Let's also not resize the height of the modal with content. Let's have it be full height, even if there are no results (and then have the overflow scrollbar as needed, just like now).
On mobile the modal could actually be full-screen with an X somewhere? This is just a thought though.
Let's distinguish the search-result-title somehow (but not with a badge 😄). Maybe just bold, or <code>/monospace (I guess code might not be appropriate for page/section titles though).

Also cc @fredrikekre -- what are your thoughts on this UX in general (i.e. replacing a separate search page with a modal)?

The other two fixes -- could you open separate PRs for those please?

sloede · 2023-08-15T07:52:44Z

Great work! From the invitation on Slack to give feedback, I took the demo site for a test drive, and these are the things I noticed (using Firefox on an M1 Macbook):

GitHub recently changed their search shortcut to press just / (or was it always that way and I just didn't know 🤔?). Why not use the same here (/ instead of Ctrl+/) to make it easier on our muscle memory?
The modal is IMHO a little too generous with vertical white space. I'd prefer a more compact result such that it is easier to scan for results further down, especially when I already know more or less what I am looking for.
At the moment there is very little to go for when trying to decide which result is the best. Maybe showing a little snippet with each result would be helpful? This might be out of scope for the PR though.
Compared to the current search info, some information seems to be missing. For example, the previous search for "parametric" also showed the section name for each result.
Right now, all filters are shown no matter what. Would it be possible to show only those filters that would return a non-empty set of search results?
Some links seem to be broken. For example, when I search for "parametric", the first result "Troubleshooting"... leads to manual/faq.html#Troubleshooting-, while the correct link should read manual/faq.html#Troubleshooting-"method-not-matched":-parametric-type-invariance-and-MethodErrors. This used to work before.
The order of the results seems to have changed, at least compared to https://docs.julialang.org/en/v1/. Not a problem, I just wasn't sure if this is intentional or not.
While an interactive modal dialogue is nice from a UI perspective, it also has some disadvantages. For example, it is not possible to bookmark the result of a search, or share it with someone else, since no URL exists. Also, when closing/reopening tabs, the search is lost. This is a structural disadvantage of modals, so nothing you can do about it per se. But maybe it would be possible to combine the best of both worlds, by allowing a user to hit "Enter" and then open a static search page (similar to how GH does it)? Then again, this may be out of scope for this PR.

Please don't take these points as criticism but rather as suggestions for further improvements. As stated above, overall great work!

KristofferC · 2023-08-15T12:03:27Z

Grabbag of unfiltered thoughts trying it out.

When I click down on the text box the browser shows some auto complete entries until I do mouse down and then they disappear and the text box shows up. It also somehow feels quite surprising to have a input text box spawn a new floating window.

These files like they should be code quoted like they are in the manual itself.

The scroll bar is very narrow for me and hard to click on with the mouse. If I am on the right half of the scroll bar it seems to not reach and I have to position the mouse on the left-most part of it

There is no need for the ... here? ctime is the full name of the function?

Is there any value in the short cut command for search being shown here? To me it makes it feels like it makes sense to use that short cut at this current moment

The recent searches list doesn't seem to ever show anything

…nto Issue-2147

Hetarth02 · 2023-08-17T17:47:38Z

Edit: 2023-08-18

Made an Issue regarding extra spacing and the PR for the same.
~~#2215 Removed some extra space between navbar header icons.~~
Moved to #2216.

~~#2103: Fixed, docstring collapse/expand icon not changing when clicking rapidly. Now click all you want!~~
Moved to #2217

Hetarth02 · 2023-08-17T19:24:41Z

@sloede

GitHub recently changed their search shortcut to press just / (or was it always that way and I just didn't know 🤔?). Why not use the same here (/ instead of Ctrl+/) to make it easier on our muscle memory?

We had discussion over this before. #2027

The modal is IMHO a little too generous with vertical white space. I'd prefer a more compact result such that it is easier to scan for results further down, especially when I already know more or less what I am looking for.

Do you mean the gap between the search results?

At the moment there is very little to go for when trying to decide which result is the best. Maybe showing a little snippet with each result would be helpful? This might be out of scope for the PR though.

While, I do not understand what you exactly mean but by hunch do you want to display a code snippet or something like that? If so, that would require some thinking(yeah, out of scope for this PR 😅)

Compared to the current search info, some information seems to be missing. For example, the previous search for "parametric" also showed the section name for each result.

We have opted to go with, title, page link and the category as for now. @mortenpi Let me know what are your thoughts on this?

Right now, all filters are shown no matter what. Would it be possible to show only those filters that would return a non-empty set of search results?

Actually, this was my initial thought but I scraped it because as per the current UI the filters changed too much(every 2 or 3 keystrokes) which can sometimes be jarring for someone, Hence I opted out from it.

Some links seem to be broken. For example, when I search for "parametric", the first result "Troubleshooting"... leads to manual/faq.html#Troubleshooting-, while the correct link should read manual/faq.html#Troubleshooting-"method-not-matched":-parametric-type-invariance-and-MethodErrors. This used to work before.

This is on purpose, because if I try to display the full link as it is in <pre> tag sometimes big links it would break the modal UI.

The order of the results seems to have changed, at least compared to https://docs.julialang.org/en/v1/. Not a problem, I just wasn't sure if this is intentional or not.

This might be due to change in search engine. #2172

While an interactive modal dialogue is nice from a UI perspective, it also has some disadvantages. For example, it is not possible to bookmark the result of a search, or share it with someone else, since no URL exists. Also, when closing/reopening tabs, the search is lost. This is a structural disadvantage of modals, so nothing you can do about it per se. But maybe it would be possible to combine the best of both worlds, by allowing a user to hit "Enter" and then open a static search page (similar to how GH does it)? Then again, this may be out of scope for this PR.

We can add features like bookmarks and search history, essentially storing it in the local storage of the browser but local storage has character limitations which vary based on devices.

Hetarth02 · 2023-08-17T19:35:49Z

@KristofferC

When I click down on the text box the browser shows some auto complete entries until I do mouse down and then they disappear and the text box shows up. It also somehow feels quite surprising to have a input text box spawn a new floating window.

Look forward to future PRs, this might be removed entirely and replaced with a icon or input tag in the top nav.

These files like they should be code quoted like they are in the manual itself.

@mortenpi If we were to do this, is there some way to know if some title is code quoted or not?

The scroll bar is very narrow for me and hard to click on with the mouse. If I am on the right half of the scroll bar it seems to not reach and I have to position the mouse on the left-most part of it

Will be fixed.

There is no need for the ... here? ctime is the full name of the function?

Will look into that.

Is there any value in the short cut command for search being shown here? To me it makes it feels like it makes sense to use that short cut at this current moment

No, those are for informative purposes only.

The recent searches list doesn't seem to ever show anything

This is just a placeholder. There is no feature for storing search history as of now. 😓

- Added modal close button - Reduced some vertical spacing - Increased scrollbar width

Hetarth02 · 2023-08-17T19:52:31Z

@mortenpi

Let's reduce the top and bottom margins. Something on the order of 1-3rem should be good.

Done

On mobile the modal could actually be full-screen with an X somewhere? This is just a thought though.

Added the "X", but it is not full-screen.

Let's distinguish the search-result-title somehow (but not with a badge 😄). Maybe just bold, or <code>/monospace (I guess code might not be appropriate for page/section titles though).

Suggestions are appreciated... 😄

The other two fixes -- could you open separate PRs for those please?

Done

mortenpi · 2023-08-18T04:31:53Z

7. Compared to the current search info, some information seems to be missing. For example, the previous search for "parametric" also showed the section name for each result.

We have opted to go with, title, page link and the category as for now. @mortenpi Let me know what are your thoughts on this?

I think this is a fair point. It would be good to keep that information somewhere in the new UI.

15. While an interactive modal dialogue is nice from a UI perspective, it also has some disadvantages. For example, it is not possible to bookmark the result of a search, or share it with someone else, since no URL exists. Also, when closing/reopening tabs, the search is lost. This is a structural disadvantage of modals, so nothing you can do about it per se. But maybe it would be possible to combine the best of both worlds, by allowing a user to hit "Enter" and then open a static search page (similar to how GH does it)? Then again, this may be out of scope for this PR.

We can add features like bookmarks and search history, essentially storing it in the local storage of the browser but local storage has character limitations which vary based on devices.

I think this is also a good point. In the current implementation, you can use the ?q= query parameter, e.g.: https://docs.julialang.org/en/v1/search/?q=ccall

That said, I just noticed it's not fully working -- if you update the search query while on the search site, it doesn't update the URL.

All in all, I think this would be nice to have, but is probably not critical. And since the current implementation is only half working, then removing this is maybe not even a regression. It would also be good to know if there are any other modal-ish searches that have a way of linking to searches.

I don't think we want to implement any UI here specifically for bookmarking though -- that should be left to the browsers etc.

Look forward to future PRs, this might be removed entirely and replaced with a icon or input tag in the top nav.

I think replacing the search input box should be done as part of this PR, since the input box doesn't really make sense if we have the modal.

Right now, all filters are shown no matter what. Would it be possible to show only those filters that would return a non-empty set of search results?

Actually, this was my initial thought but I scraped it because as per the current UI the filters changed too much(every 2 or 3 keystrokes) which can sometimes be jarring for someone, Hence I opted out from it.

Let's gray out the irrelevant filters maybe? That would be less jarring than DOM elements hopping in and out of existence.

@mortenpi If we were to do this, is there some way to know if some title is code quoted or not?

I think we have to look at the class? Functions and types would be code, sections and such would be text. It's also possible to have code in section titles, but let's ignore that for now.

Some links seem to be broken. For example, when I search for "parametric", the first result "Troubleshooting"... leads to manual/faq.html#Troubleshooting-, while the correct link should read manual/faq.html#Troubleshooting-"method-not-matched":-parametric-type-invariance-and-MethodErrors. This used to work before.

This is on purpose, because if I try to display the full link as it is in
 tag sometimes big links it would break the modal UI.

There's a bug here too -- note the href here which is wrong (it's cut off).

<a href="./manual/faq.html#Troubleshooting-" method-not-matched":-parametric-type-invariance-and-methoderrors"="" class="search-result-link w-100 is-flex is-flex-direction-column gap-2 p-4">
        <div class="w-100 is-flex is-flex-wrap-wrap is-justify-content-space-between is-align-items-center">
          <div class="search-result-title has-text-weight-semi-bold">Troubleshooting "method not matched": parametric type invariance and MethodErrors</div>
          <div class="property-search-result-badge">section</div>
        </div>
        <p>
          
        </p>
        <div class="has-text-left" style="font-size: smaller;" title="manual/faq.html#Troubleshooting-" method-not-matched":-parametric-type-invariance-and-methoderrors"="">
          <i class="fas fa-link"></i> manual/faq.html#Troubleshooting-"method-not-matche...
        </div>
      </a>

Of course, Documenter also generates pretty crazy ids/fragments sometimes. But I think it should work as is, and point to https://mortenpi.eu/juliadocs-demos/2023-08-10-search-demo/manual/faq.html#Troubleshooting-%22method-not-matched%22:-parametric-type-invariance-and-MethodErrors.

sloede · 2023-08-18T07:24:21Z

@Hetarth02

The modal is IMHO a little too generous with vertical white space. I'd prefer a more compact result such that it is easier to scan for results further down, especially when I already know more or less what I am looking for.

Do you mean the gap between the search results?

Yes. There is a lot of vertical whitespace that IMHO would be put to better use by being able to view more results at once (i.e., by reducing the vertical whitespace).

At the moment there is very little to go for when trying to decide which result is the best. Maybe showing a little snippet with each result would be helpful? This might be out of scope for the PR though.

While, I do not understand what you exactly mean but by hunch do you want to display a code snippet or something like that? If so, that would require some thinking(yeah, out of scope for this PR 😅)

For example, Read the Docs provides a small glimpse at the content of the search result, such that one can more easily decide which of the results is likely to be most useful to the user:

Some links seem to be broken. For example, when I search for "parametric", the first result "Troubleshooting"... leads to manual/faq.html#Troubleshooting-, while the correct link should read manual/faq.html#Troubleshooting-"method-not-matched":-parametric-type-invariance-and-MethodErrors. This used to work before.

This is on purpose, because if I try to display the full link as it is in \<pre\> tag sometimes big links it would break the modal UI.

The displayed part of the link, i.e., the 123 in <a href="abc">123</a>, should be shortened, yes, but not the actual URL in the link (abc in this example), right? Otherwise, clicking on those links might become useless very quickly.

While an interactive modal dialogue is nice from a UI perspective, it also has some disadvantages. For example, it is not possible to bookmark the result of a search, or share it with someone else, since no URL exists. Also, when closing/reopening tabs, the search is lost. This is a structural disadvantage of modals, so nothing you can do about it per se. But maybe it would be possible to combine the best of both worlds, by allowing a user to hit "Enter" and then open a static search page (similar to how GH does it)? Then again, this may be out of scope for this PR.

We can add features like bookmarks and search history, essentially storing it in the local storage of the browser but local storage has character limitations which vary based on devices.

No, don't store anything in the browser. But maybe you can do something like Read the Docs does: When you type in a search term, e.g., "search" (see picture above), they also automatically update the URL:

This allows one to close the browser tab and reopen it, and it will be exactly at the same place again. Also, it allows me to copy the URL and share it with someone else (like so) and they will be able to access the same search results.

sloede · 2023-08-18T07:26:53Z

@mortenpi

All in all, I think this would be nice to have, but is probably not critical. And since the current implementation is only half working, then removing this is maybe not even a regression. It would also be good to know if there are any other modal-ish searches that have a way of linking to searches.

Yes, e.g., Read the Docs.

I don't think we want to implement any UI here specifically for bookmarking though -- that should be left to the browsers etc.

I agree and this is not what I had in mind. I hope in my answer above it becomes clearer.

mortenpi · 2023-08-18T07:38:15Z

5. At the moment there is very little to go for when trying to decide which result is the best. Maybe showing a little snippet with each result would be helpful? This might be out of scope for the PR though.

While, I do not understand what you exactly mean but by hunch do you want to display a code snippet or something like that? If so, that would require some thinking(yeah, out of scope for this PR 😅)

For example, Read the Docs provides a small glimpse at the content of the search result, such that one can more easily decide which of the results is likely to be most useful to the user:

Hetarth's implementation does show context in some cases now:

Although it does looks like for the Julia manual a lot of them are missing somehow. @Hetarth02 any ideas why?

In some cases we're probably missing the context in the index. E.g. if we're matching just the title or function name, we should probably show like the first bit of the section or docstring. But I don't think we have that information currently in the index. That should be looked at in a follow-up PR though -- let's not change the index here.

mortenpi · 2023-08-18T07:41:19Z

It would also be good to know if there are any other modal-ish searches that have a way of linking to searches.

Yes, e.g., Read the Docs.

Ah, cool. Yeah, I think we can take inspiration from that, and just update a query parameter (either in this PR, or a follow-up).

Side note: RTD also uses / for the search hotkey.

…nto Issue-2147

- Made the result title bold to better differentiate - Titles for results in function, module, etc. will be in monospace - Added section titles at the end of url - Replaced "No recent searches!" placeholder text - The sidebar input box has been replaced with a div - Fixed a bug where some URLs with special characters didn't generated fully - Updated comments

Hetarth02 · 2023-08-20T14:25:15Z

Edit: 2023-08-20

@mortenpi

Have the modal be full size all the time on desktop too.

Desktop:

Mobile:

Distinguish the search-result-title. (Made it bold)

Have the search-result-title for code items (like function names and such; anything except Page, Section) in monospace.

Add section titles to search results (add to the bottom near the URL somehow).

Remove / replace the "No recent searches!" string, as it's confusing. Replace with Type something to get started.

Get rid of the search input box (Replaced the input with div).
Fix the bug with some URLs incorrectly being cut off (search "parametric")

This should be working, I have tested it locally but it would be helpful if someone can verify this with different urls.

thazhemadam · 2023-08-21T03:52:11Z

After you have already searched for something and navigated to the respective documentation, if you search for something else that falls in the same section, the search modal doesn't go away. The documentation itself apparently navigates properly within the same section, but the search modal still stays on the screen.
This is not consistent with the behavior observed while searching for and navigating to different sections of the documentation (which imo is a nicer user experience - not having to manually close the search modal every time they search something).

mortenpi · 2023-08-21T04:28:23Z

One more option for what to put in the search modal when it's not showing any results 😛

mortenpi · 2023-08-21T04:29:20Z

After you have already searched for something and navigated to the respective documentation, if you search for something else that falls in the same section, the search modal doesn't go away.

Good catch! I can also replicate this. cc @Hetarth02 -- this would be good to get fixed.

mortenpi

Nice! A few more comments, now that I'm looking more closely at the code:

Is there any reason to have shortcut.js separate from search.js? Although, maybe the files are getting big enough that it does make sense to split them up.
I think we also still need to remove the generation of search/index.html? I didn't see that change in the Julia code?

assets/html/scss/documenter/layout/_search.scss

mortenpi · 2023-08-21T04:42:31Z

assets/html/scss/documenter/layout/_search.scss

+// Helpers for search modal
+.w-100 {
+  width: 100%;
+}
+
+.gap-2 {
+  gap: 0.5rem;
+}
+
+.gap-4 {
+  gap: 1rem;
+}
+
+.gap-8 {
+  gap: 2rem;
 }


We can leave this as is, but in general I am not a fan of these kinds of helpers -- essentially you're using HTML to do the styling again.

I find these kinds of helper more useful, maybe it has to do something with me using bootstrap normally...

src/html/HTMLWriter.jl

CHANGELOG.md

mortenpi · 2023-08-21T06:29:52Z

Here's an updated Julia manual demo: https://mortenpi.eu/juliadocs-demos/2023-08-21-search-demo/

…nto Issue-2147

- Fix modal not closing when url on same page - Changes as per feeback

Hetarth02 · 2023-08-21T19:34:18Z

@mortenpi

Is there any reason to have shortcut.js separate from search.js? Although, maybe the files are getting big enough that it does make sense to split them up.

If possible, let us keep this as it is for the moment.

I think we also still need to remove the generation of search/index.html? I didn't see that change in the Julia code?

Done

Hetarth02 · 2023-08-21T19:34:54Z

@mortenpi @thazhemadam

After you have already searched for something and navigated to the respective documentation, if you search for something else that falls in the same section, the search modal doesn't go away.

Good catch! I can also replicate this. cc @Hetarth02 -- this would be good to get fixed.

Done!

mortenpi

LGTM! In my opinion we can merge this. Just needs the CSS files to be updated.

…nto Issue-2147

Hetarth02 · 2023-08-23T13:46:01Z

LGTM! In my opinion we can merge this. Just needs the CSS files to be updated.

Done

@mortenpi
I think this PR should also close Issues #1986, #1437, #1749, #1457, #1832.

mortenpi

Awesome! Thanks a lot @Hetarth02 for iterating on this! And thanks everyone for the feedback!

Squashed commit of the following: commit da6d4f8 Author: Hetarth Shah <[email protected]> Date: Tue Jan 23 23:52:14 2024 +0530 - Added div at end of file to store metadata - Added metadata.js commit e250ebb Merge: 85828de aac2ea9 Author: Hetarth Shah <[email protected]> Date: Tue Jan 23 23:08:14 2024 +0530 Merge branch 'master' of https://github.com/Hetarth02/Documenter.jl commit 85828de Merge: b2feabd c5a89ab Author: Hetarth Shah <[email protected]> Date: Sun Dec 10 13:20:11 2023 +0530 Merge branch 'JuliaDocs:master' into master commit b2feabd Merge: be00b02 28c5186 Author: Hetarth Shah <[email protected]> Date: Mon Nov 13 16:35:25 2023 +0530 Merge branch 'JuliaDocs:master' into master commit be00b02 Merge: 60ca700 7f7c4bd Author: Hetarth Shah <[email protected]> Date: Mon Nov 13 09:05:23 2023 +0530 Merge branch 'JuliaDocs:master' into master commit 60ca700 Merge: 24d8a5f efb3ab4 Author: Hetarth Shah <[email protected]> Date: Fri Nov 10 16:55:57 2023 +0530 Merge branch 'JuliaDocs:master' into master commit 24d8a5f Merge: 149bdd0 c6abf9d Author: Hetarth Shah <[email protected]> Date: Sat Nov 4 08:01:50 2023 +0530 Merge branch 'JuliaDocs:master' into master commit 149bdd0 Merge: 984ef8c a86549b Author: Hetarth Shah <[email protected]> Date: Sun Oct 15 15:40:57 2023 +0530 Merge branch 'master' of https://github.com/Hetarth02/Documenter.jl commit 984ef8c Merge: f32d6de a232dd4 Author: Hetarth Shah <[email protected]> Date: Tue Sep 26 23:00:19 2023 +0530 Merge branch 'master' of https://github.com/Hetarth02/Documenter.jl commit f32d6de Merge: defe107 bb1dbc4 Author: Hetarth Shah <[email protected]> Date: Thu Aug 24 12:23:09 2023 +0530 Merge branch 'master' of https://github.com/Hetarth02/Documenter.jl commit defe107 Author: Hetarth Shah <[email protected]> Date: Thu Aug 24 12:22:22 2023 +0530 New Search Modal UI (#2202) commit bb1dbc4 Merge: 724bd89 e2bd194 Author: Hetarth Shah <[email protected]> Date: Thu Aug 24 11:48:16 2023 +0530 Merge branch 'master' of https://github.com/Hetarth02/Documenter.jl commit 724bd89 Author: Hetarth Shah <[email protected]> Date: Sun Jul 16 19:08:27 2023 +0530 - Corrected typo commit 1fb8e07 Author: Hetarth Shah <[email protected]> Date: Sun Jul 16 19:05:48 2023 +0530 - Updated the duplication issue - Updated the UI for the actual search results commit 34303e0 Merge: b858db5 4643dbf Author: Hetarth Shah <[email protected]> Date: Sun Jul 16 14:00:18 2023 +0530 Merge branch 'master' of https://github.com/Hetarth02/Documenter.jl into Issue-2141 commit b858db5 Author: Hetarth Shah <[email protected]> Date: Thu Jul 6 01:28:29 2023 +0530 - Changed LunrJs to MinisearchJs for client-side search

Hetarth02 added 2 commits August 6, 2023 17:38

- Added a fresh new Search UI

97f261c

- Fixed the collapse/expand issue when clicked repeatedly - Remove extra space from the navbar header icons

- Updated CHANGELOG.md

44b191f

Hetarth02 changed the title ~~Issue 2147~~ New Search Modal UI Aug 6, 2023

mortenpi mentioned this pull request Aug 7, 2023

Increase relevance of (partial) exact matches #2203

Closed

mortenpi added Type: Enhancement Format: HTML Related to the default HTML output labels Aug 10, 2023

Hetarth02 added 2 commits August 17, 2023 22:25

Merge branch 'master' of https://github.com/Hetarth02/Documenter.jl i…

73e5ad7

…nto Issue-2147

- Removed commits for other fixes

184d9f0

- Added new code comments for better understanding

a43afe9

- Added modal close button - Reduced some vertical spacing - Increased scrollbar width

Hetarth02 added 2 commits August 20, 2023 15:36

Merge branch 'master' of https://github.com/Hetarth02/Documenter.jl i…

ffaa26f

…nto Issue-2147

mortenpi reviewed Aug 21, 2023

View reviewed changes

Hetarth02 added 2 commits August 22, 2023 00:08

Merge branch 'master' of https://github.com/Hetarth02/Documenter.jl i…

653d48c

…nto Issue-2147

- Remove render search page function

1004f75

- Fix modal not closing when url on same page - Changes as per feeback

mortenpi approved these changes Aug 22, 2023

View reviewed changes

mortenpi added this to the 1.0.0 milestone Aug 22, 2023

Merge branch 'master' of https://github.com/Hetarth02/Documenter.jl i…

dc15b89

…nto Issue-2147

update issue references

7726507

mortenpi approved these changes Aug 23, 2023

View reviewed changes

mortenpi enabled auto-merge (squash) August 23, 2023 23:48

mortenpi mentioned this pull request Aug 23, 2023

Enhance at-index to list section names, like the search index #1986

Open

mortenpi merged commit e2bd194 into JuliaDocs:master Aug 23, 2023

Hetarth02 deleted the Issue-2147 branch August 24, 2023 06:11

Hetarth02 added a commit to Hetarth02/Documenter.jl that referenced this pull request Aug 24, 2023

New Search Modal UI (JuliaDocs#2202)

defe107

LilithHafner mentioned this pull request Jan 19, 2024

Search filter toggle buttons have broken UI [regression] #2406

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Search Modal UI #2202

New Search Modal UI #2202

Hetarth02 commented Aug 6, 2023 •

edited by mortenpi

Loading

Hetarth02 commented Aug 6, 2023

mortenpi commented Aug 10, 2023

sloede commented Aug 15, 2023

KristofferC commented Aug 15, 2023

Hetarth02 commented Aug 17, 2023

Hetarth02 commented Aug 17, 2023

Hetarth02 commented Aug 17, 2023 •

edited

Loading

Hetarth02 commented Aug 17, 2023 •

edited

Loading

mortenpi commented Aug 18, 2023

sloede commented Aug 18, 2023

sloede commented Aug 18, 2023

mortenpi commented Aug 18, 2023 •

edited

Loading

mortenpi commented Aug 18, 2023 •

edited

Loading

Hetarth02 commented Aug 20, 2023

thazhemadam commented Aug 21, 2023

mortenpi commented Aug 21, 2023

mortenpi commented Aug 21, 2023

mortenpi left a comment

mortenpi Aug 21, 2023

Hetarth02 Aug 21, 2023

mortenpi commented Aug 21, 2023 •

edited

Loading

Hetarth02 commented Aug 21, 2023

Hetarth02 commented Aug 21, 2023

mortenpi left a comment

Hetarth02 commented Aug 23, 2023 •

edited

Loading

mortenpi left a comment

New Search Modal UI #2202

New Search Modal UI #2202

Conversation

Hetarth02 commented Aug 6, 2023 • edited by mortenpi Loading

Light Mode:

Dark Mode:

Hetarth02 commented Aug 6, 2023

mortenpi commented Aug 10, 2023

sloede commented Aug 15, 2023

KristofferC commented Aug 15, 2023

Hetarth02 commented Aug 17, 2023

Hetarth02 commented Aug 17, 2023

Hetarth02 commented Aug 17, 2023 • edited Loading

Hetarth02 commented Aug 17, 2023 • edited Loading

mortenpi commented Aug 18, 2023

sloede commented Aug 18, 2023

sloede commented Aug 18, 2023

mortenpi commented Aug 18, 2023 • edited Loading

mortenpi commented Aug 18, 2023 • edited Loading

Hetarth02 commented Aug 20, 2023

thazhemadam commented Aug 21, 2023

mortenpi commented Aug 21, 2023

mortenpi commented Aug 21, 2023

mortenpi left a comment

Choose a reason for hiding this comment

mortenpi Aug 21, 2023

Choose a reason for hiding this comment

Hetarth02 Aug 21, 2023

Choose a reason for hiding this comment

mortenpi commented Aug 21, 2023 • edited Loading

Hetarth02 commented Aug 21, 2023

Hetarth02 commented Aug 21, 2023

mortenpi left a comment

Choose a reason for hiding this comment

Hetarth02 commented Aug 23, 2023 • edited Loading

mortenpi left a comment

Choose a reason for hiding this comment

Hetarth02 commented Aug 6, 2023 •

edited by mortenpi

Loading

Hetarth02 commented Aug 17, 2023 •

edited

Loading

Hetarth02 commented Aug 17, 2023 •

edited

Loading

mortenpi commented Aug 18, 2023 •

edited

Loading

mortenpi commented Aug 18, 2023 •

edited

Loading

mortenpi commented Aug 21, 2023 •

edited

Loading

Hetarth02 commented Aug 23, 2023 •

edited

Loading