-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase relevance of (partial) exact matches #2203
Comments
Cc @Hetarth02 |
Then filtering in #2202 should also help with that a bit. It would actually be good to get a bit of feedback on that, whether that's good UX or not. |
I am confused about what the fuzzy search distance should be. If it is very much then one can get unwanted results and if its less(the case right now) we already know as mentioned above. We should probably try out some distances with this, but I would suggest not going farther than 3. |
I think the point here is that we want the matches that match exactly to be prioritized, and fuzzy matches shown a bit lower? The exact fuzzy distance in that sense is irrelevant here. |
Hmm, so basically a mix of exact and fuzzy searches could be a good thing...? Like have top 10 or so searches which are exact matches and others with fuzzy, sound reasonable? |
Yep, I think so. I am not sure you need to limit the number of exact matches though? They should probably always be prioritized? The only thing to think about is e.g. module names.. if we have those in the "title", then they might be very repetitive. |
Also, we might need to limit one or other search because either of them can have repetitive results which we don't want. |
I feel that, ideally, repetitive results should be removed, rather than working around the problem by just throwing away (potentially) correct results because were hitting some arbitrary limit. |
Just switched https://juliatesting.github.io/Aqua.jl/dev to use Documenter 1.0, and tried the new search:
All in all I think that perfect prefixes need to be considered much more strongly... (OK, old Documenter search also was weird; e.g. |
Minisearch has a separate option for enabling prefix searches, so it looks like just adding Instead of They don't specify whether prefix-matched results are ranked lower than exact matches in their docs. It seems like that should be the case based on this discussion, but that's worth verifying. |
Thanks for this, will probably look into it this weekend. |
I played around a bit with the new search functionality and this is issue is essentially the same request as in #2141 (comment)
In 99% of cases I know the exact function I am looking for so it would be great to increase the importance of exact matches. As it is right now it is IMO a bit annoying since you essentially have to type out the whole name until you get a match.
The text was updated successfully, but these errors were encountered: