-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand code-like blocks in nested contexts #1970
Conversation
I'm taking the liberty to ping this once more, because I'm not sure whether this is stalling because the people in charge are busy or because my fix to the unit tests has gone by unnoticed. |
Can you add a note in the changelog? |
Done! |
Not sure why some tests fail, but I suspect it's caused by something outside the scope of this PR. The tests used to pass before the last two commits, and since then I've only changed the changelog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Just a couple of tiny nitpicks.
Could you add the new example page to pages
here:
Documenter.jl/test/examples/make.jl
Lines 181 to 213 in 998d26e
htmlbuild_pages = Any[ | |
"**Home**" => "index.md", | |
"Manual" => [ | |
"man/tutorial.md", | |
"man/style.md", | |
], | |
hide("hidden.md"), | |
"Library" => [ | |
"lib/functions.md", | |
"lib/autodocs.md", | |
], | |
hide("Hidden Pages" => "hidden/index.md", Any[ | |
"Page X" => "hidden/x.md", | |
"hidden/y.md", | |
"hidden/z.md", | |
]), | |
"Expandorder" => [ | |
"expandorder/00.md", | |
"expandorder/01.md", | |
"expandorder/AA.md", | |
], | |
"unicode.md", | |
"latex.md", | |
"example-output.md", | |
"fonts.md", | |
"linenumbers.md", | |
"EditURL" => [ | |
"editurl/good.md", | |
"editurl/bad.md", | |
"editurl/ugly.md", | |
], | |
"xrefs.md", | |
] |
The test failures indeed look unrelated.
I can replicate the test failures locally and outside of Julia as well, and it looks like it's this: https://bugs.launchpad.net/ubuntu/+source/git/+bug/1993586 |
Co-authored-by: Morten Piibeleht <[email protected]>
Done |
Thanks a lot @ettersi! |
Thank you! Documenter is a great tool, and I'm very grateful to everyone who has helped shape it into what it is today! |
Btw, is there a rough guesstimate for when the next version will be released? |
Not really, no. I did some thinking, and I would like to get a few more things into 0.28. People get somewhat annoyed with breaking Documenter releases, so I would like batch up as many (breaking or potentially breaking) things as we can. I am a little low on bandwidth, but I am planning on putting some time into those issues over the next few weeks. However, a good thing about Documenter deployments is that you can just commit a |
Fixes #491. This PR is heavily inspired by the previous work in #1637 and #1747
Edit by @mortenpi: close #1747 .