Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

```@repl block inside !!! note doesn't show output #491

Closed
shashi opened this issue May 25, 2017 · 10 comments · Fixed by #1970
Closed

```@repl block inside !!! note doesn't show output #491

shashi opened this issue May 25, 2017 · 10 comments · Fixed by #1970

Comments

@shashi
Copy link
Contributor

shashi commented May 25, 2017

@repl block inside an !!! note is neither stylized as the REPL nor is the output shown. Is this intended?

@mortenpi
Copy link
Member

Can confirm. Other special blocks seem to be ignored in admonitions as well. Thanks for the report!

@mortenpi
Copy link
Member

I'm rather sure that the issue comes from src/Expanders.jl#L25-L32 -- the expander functions are only called on top-level blocks, and not recursively through the AST.

@nluetts
Copy link

nluetts commented Sep 18, 2020

I just stumbled upon the same problem---is it not resolved yet? Or is there a workaround?

@ettersi
Copy link
Contributor

ettersi commented Oct 12, 2022

I'd really like to see this fixed, and I'm happy to give a hand doing so. However, since there have already been two attempts which seem to eventually have run out of steam, I thought I'd ask for some input first on what people think would be the best way to resolve this.

@KristofferC
Copy link
Member

Is there anything wrong with #1747?

@ettersi
Copy link
Contributor

ettersi commented Oct 12, 2022

Yes - it isn't merged yet! 😉 Other than that, I'm wondering the same.

@mortenpi
Copy link
Member

mortenpi commented Oct 16, 2022

#1747 contains some unnecessary changes as far as I can tell. But I think the general approach there is good (create a new expander step that recurses for certain elements, but only calls a subset of expander steps then). It needs to be updated to the new MarkdownAST-based tree though. @ettersi I'd say you're welcome to adopt that PR to finish it up if you'd like.

@ettersi
Copy link
Contributor

ettersi commented Oct 17, 2022

What's the recommended way to "adopt" a PR? I believe I can't fork a PR. I can of course create a new PR, but that would erase @jmert from the history, which doesn't seem fair.

@mortenpi
Copy link
Member

You'd have to start a new PR on your fork, but you can use their latest commit as a starting point (although, it might be easier to just re-do it from scratch, since merging with master might be more work at this point). One way or another, I'll make sure that there is a Co-Authored-By in the commit message when we merge.

@ettersi
Copy link
Contributor

ettersi commented Oct 18, 2022

Done: #1970

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants