Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Too much space in multiline @repl block #1770

Closed
simonmandlik opened this issue Mar 1, 2022 · 6 comments · Fixed by #1771
Closed

Too much space in multiline @repl block #1770

simonmandlik opened this issue Mar 1, 2022 · 6 comments · Fixed by #1771
Labels
Format: HTML Related to the default HTML output Type: Bug

Comments

@simonmandlik
Copy link

See: https://juliadocs.github.io/Documenter.jl/stable/showcase/#REPL-type

Is this intended?
@fredrikekre
Copy link
Member

No.

@fredrikekre
Copy link
Member

fredrikekre commented Mar 1, 2022 •
edited
Loading

Looks like a CSS bug, maybe #1759 @pfitzseb ? It was not present in version 0.27.12 so something changed here: v0.27.12...v0.27.13

@pfitzseb pfitzseb mentioned this issue Mar 2, 2022
Merged
fredrikekre pushed a commit that referenced this issue Mar 2, 2022
@pfitzseb
Fix repl-code-block styling, fixes #1770. (#1771)
1824adc
@fredrikekre fredrikekre reopened this Mar 8, 2022
@fredrikekre
Copy link
Member

@pfitzseb I still see this in the light theme, but dark one is fixed. See e.g. https://julialogging.github.io/previews/PR1234/tutorials/logging-basics/

@pfitzseb
Copy link
Member

pfitzseb commented Mar 9, 2022

That case happens because of the gruvbox code theme overwriting the CSS changes in here. Can you give #1774 a go?

@fredrikekre
Copy link
Member

Ah okay. I thought they were pure color theme files...

@pfitzseb
Copy link
Member

pfitzseb commented Mar 9, 2022

Yeah, same, but apparently not:
image

@pfitzseb pfitzseb closed this as completed Mar 9, 2022
@mortenpi mortenpi added Type: Bug Format: HTML Related to the default HTML output labels Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Format: HTML Related to the default HTML output Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix repl-code-block styling JuliaDocs/Documenter.jl
4 participants
@mortenpi @pfitzseb @fredrikekre @simonmandlik