Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch off ligatures by default? #1610

Closed
cormullion opened this issue Jun 23, 2021 · 4 comments · Fixed by #1617
Closed

Switch off ligatures by default? #1610

cormullion opened this issue Jun 23, 2021 · 4 comments · Fixed by #1617
Labels
Format: HTML Related to the default HTML output Type: Bug
Milestone

Comments

@cormullion
Copy link
Contributor

People have surprisingly strong opinions about fonts, especially when it comes to things like contextual and stylistic alternates (aka ligatures) in monospaced fonts.

Leaving aside personal taste, I'd suggest that in documentation their presence might need explanation, since it might not be easily apparent to everyone that what looks like an arrow is actually formed by typing - and >.

I wonder whether it would be better to have them switched off by default, for documents such as the Julia manual, but have them able to be switched on for documents where basic Julia knowledge is assumed.

@fredrikekre
Copy link
Member

Would be good to at least document how to turn it off (as for the Julia manual). Of course, I would prefer making that default and document how to turn it on instead.

@KristofferC
Copy link
Member

KristofferC commented Jun 26, 2021

I also think that default to ligatures off makes sense.

@cormullion
Copy link
Contributor Author

Is there an easy way to inject CSS into the provided themes? I used to have to edit them manually to make tweaks, which was a bit of a nuisance. The Julia manual had a handy CSS file, but is there similar for Documenter?

@mortenpi mortenpi added Format: HTML Related to the default HTML output Type: Bug labels Jun 29, 2021
@mortenpi mortenpi added this to the 0.27.3 milestone Jun 29, 2021
@mortenpi
Copy link
Member

I did not realize that JuliaMono uses ligatures. I strongly agree that they should not be enabled by default (#1617).

I also do not think that manuals should really use them at all by default -- most people who read a manual of any package are likely not familiar with ligatures. For that reason I don't necessarily think it is a bad thing if we do not let manual authors enable them easily.

I would not mind a per-user option (e.g. another toggle next to the theme one), but I am not sure how much use it would get (mostly because you'd have to enable it for each package separately).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Format: HTML Related to the default HTML output Type: Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants