Skip to content

Commit

Permalink
Fix deprecation warning in SCSS compilation (#2145)
Browse files Browse the repository at this point in the history
* Fix deprecation warning in SCSS compilation

(cherry picked from commit 7758bd8)
  • Loading branch information
mortenpi committed Jul 3, 2023
1 parent fc5af8b commit 5bf7fbc
Show file tree
Hide file tree
Showing 3 changed files with 35 additions and 6 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## Version `v0.27.25`

* ![Bugfix][badge-bugfix] Page headings are now correctly escaped in `LaTeXWriter`. ([#2134][github-2134])
* ![Bugfix][badge-bugfix] Compiling the dark theme with Sass no longer emits deprecation warnings about `!global` assignments. ([#1766][github-1766], [#1983][github-1983], [#2145][github-2145])

## Version `v0.27.24`

Expand Down Expand Up @@ -1058,6 +1059,7 @@
[github-1759]: https://github.com/JuliaDocs/Documenter.jl/pull/1759
[github-1760]: https://github.com/JuliaDocs/Documenter.jl/issues/1760
[github-1762]: https://github.com/JuliaDocs/Documenter.jl/pull/1762
[github-1766]: https://github.com/JuliaDocs/Documenter.jl/issues/1766
[github-1770]: https://github.com/JuliaDocs/Documenter.jl/issues/1770
[github-1771]: https://github.com/JuliaDocs/Documenter.jl/pull/1771
[github-1772]: https://github.com/JuliaDocs/Documenter.jl/issues/1772
Expand Down Expand Up @@ -1102,8 +1104,10 @@
[github-1886]: https://github.com/JuliaDocs/Documenter.jl/pull/1886
[github-1908]: https://github.com/JuliaDocs/Documenter.jl/pull/1908
[github-1909]: https://github.com/JuliaDocs/Documenter.jl/pull/1909
[github-1983]: https://github.com/JuliaDocs/Documenter.jl/issues/1983
[github-2018]: https://github.com/JuliaDocs/Documenter.jl/pull/2018
[github-2134]: https://github.com/JuliaDocs/Documenter.jl/pull/2134
[github-2145]: https://github.com/JuliaDocs/Documenter.jl/pull/2145
<!-- end of issue link definitions -->

[julia-38054]: https://github.com/JuliaLang/julia/issues/38054
Expand Down
5 changes: 5 additions & 0 deletions assets/html/scss/documenter-dark.scss
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@ $admonition-background: (
'danger': $background, 'compat': $background
);
$admonition-header-background: ('default': $grey);
// These would normally get initialized in _admonition.scss. However, since we are not
// loading it on the top level, we need to set them here too to avoid deprecation warnings.
// https://github.com/JuliaDocs/Documenter.jl/issues/1766
$admonition-header-color: ();
$admonition-body-color: ();

$body-size: 16px;
$documenter-sidebar-background: $grey-darker;
Expand Down
32 changes: 26 additions & 6 deletions assets/html/themes/documenter-dark.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 5bf7fbc

Please sign in to comment.