Use proper sandbox for at-setup blocks too

Apply the fix from #794 to also SetupBlocks. Fix #1148.
JuliaDocs · Oct 9, 2019 · 11b0994 · 11b0994
1 parent 51ad36b
commit 11b0994
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/Expanders.jl b/src/Expanders.jl
@@ -641,7 +641,7 @@ function Selectors.runner(::Type{SetupBlocks}, x, page, doc)
     # The sandboxed module -- either a new one or a cached one from this page.
     name = matched[1]
     sym  = isempty(name) ? gensym("ex-") : Symbol("ex-", name)
-    mod  = get!(page.globals.meta, sym, Module(sym))::Module
+    mod  = get!(() -> get_new_sandbox(sym), page.globals.meta, sym)
 
     # Evaluate whole @setup block at once instead of piecewise
     page.mapping[x] =

diff --git a/test/examples/src/index.md b/test/examples/src/index.md
@@ -402,6 +402,19 @@ julia> ans
 "world"
 ```
 
+## Issue #1148
+
+```@setup setup-include-test
+write("issue1148.jl", "x = 1148")
+r = include("issue1148.jl")
+rm("issue1148.jl")
+```
+
+```@repl setup-include-test
+x
+@assert x == 1148
+```
+
 # Issue513
 
 ```jldoctest named