Add missing methods for add! and subst! #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are passing on 0.6 and nightly (added corresponding tests for new code) |
|
Thanks! I'll merge this to the mutating_functions branch. |
lbenet
pushed a commit
that referenced
this pull request
Oct 10, 2017
* Add missing in-place methods for unary +,- * Add tests for new add!, subst! methods
lbenet
added a commit
that referenced
this pull request
Oct 27, 2017
* Use explicit recursion for acos in acos! ... ...instead of using asin! * Add internalmutfunct.jl * Add unary add! subst! and other methods, and ammend dictionaries * Small corrections * Add mul! and div! involving numeric coefficients * Rename internalmutfunct.jl to dictmutfunct.jl and export constant_term * Add identity! and another method of constant_term * Add zero! and one! methods * Include in _internalmutfunc_call TayloSeries before the function * Revise the docstrings * Add specific cases depending on the power to `pow!` * Add missing methods for add! and subst! (#117) * Add missing in-place methods for unary +,- * Add tests for new add!, subst! methods * Add `abs!` * Add `abs2(a)` as `a^2`, and the corresponding `abs2!` * Correct `abs!` so it works for Taylor1{TaylorN{T}} * Import abs2 * Add tests for some mutating functions and dictionary calls * Fix some deprecations warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some methods for
add!andsubst!, such asadd!(v::Taylor1,a::NumberNotSeries,k::Int), and analogous versions forTaylorNs, which come in handy when working together with PerezHz/TaylorIntegration.jl#31