-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new syntax of Julia 0.6 #115
Conversation
4f4cd69
to
fb4b2a4
Compare
Have you seen |
I heard, and forgot about it :-P Thanks for reminding me. |
Is this still WIP? |
I have just changed the title of this PR. While I think this is essentially done, I think a new version (0.5.1) should be released that is the last one supporting Julia 0.5. This could then be merged, and perhaps we should also tag a new version (0.6.0) which includes this PR. Following this plan, a few changes may still be needed... @dpsanders What do you think about this? |
I agree with making a final 0.5 release if there's something new. |
This includes `struct`, inner constructors and `where` syntax.
c5cfd6e
to
5c314d9
Compare
(Rebased to current master) |
I just tagged v0.5.1, commit 909689b, with a bunch of additions; it is the last version compatible with Julia 0.5.+. The idea is, once that version is in accepted in METADATA, this PR can be merged and it will tagged as v0.6.0. This supports Julia 0.6.0+ and above. Tests are passing. |
ec757f7
to
943dcfb
Compare
I have retouched and updated some parts of the docs. I think this is ready to be merged and tagged as 0.6, so we drop support to Julia 0.5.x. Do you agree @dpsanders ? |
Yes, great, go ahead! |
Done! I just tagged and submitted the PR to METADAT. |
This is WIP aimed to use the new syntax introduced in Julia 0.6, to eventually drop the support for Julia 0.5.x.