Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new syntax of Julia 0.6 #115

Merged
merged 7 commits into from
Oct 9, 2017
Merged

Use new syntax of Julia 0.6 #115

merged 7 commits into from
Oct 9, 2017

Conversation

lbenet
Copy link
Member

@lbenet lbenet commented Aug 22, 2017

This is WIP aimed to use the new syntax introduced in Julia 0.6, to eventually drop the support for Julia 0.5.x.

@coveralls
Copy link

coveralls commented Aug 22, 2017

Coverage Status

Coverage increased (+1.7%) to 95.837% when pulling fb4b2a4 on deprecations0.6 into 2381ad4 on master.

@coveralls
Copy link

coveralls commented Aug 22, 2017

Coverage Status

Coverage increased (+1.7%) to 95.837% when pulling c5cfd6e on deprecations0.6 into 2381ad4 on master.

@dpsanders
Copy link
Contributor

@lbenet
Copy link
Member Author

lbenet commented Aug 23, 2017

I heard, and forgot about it :-P

Thanks for reminding me.

@blas-ko
Copy link
Contributor

blas-ko commented Aug 25, 2017

Is this still WIP?

@lbenet lbenet changed the title WIP: Use new syntax of Julia 0.6 Use new syntax of Julia 0.6 Aug 25, 2017
@lbenet
Copy link
Member Author

lbenet commented Aug 25, 2017

I have just changed the title of this PR.

While I think this is essentially done, I think a new version (0.5.1) should be released that is the last one supporting Julia 0.5. This could then be merged, and perhaps we should also tag a new version (0.6.0) which includes this PR. Following this plan, a few changes may still be needed...

@dpsanders What do you think about this?

@dpsanders
Copy link
Contributor

I agree with making a final 0.5 release if there's something new.

@lbenet
Copy link
Member Author

lbenet commented Oct 8, 2017

(Rebased to current master)

@coveralls
Copy link

coveralls commented Oct 8, 2017

Coverage Status

Coverage increased (+1.6%) to 97.11% when pulling 2db7c27 on deprecations0.6 into 909689b on master.

@lbenet
Copy link
Member Author

lbenet commented Oct 8, 2017

I just tagged v0.5.1, commit 909689b, with a bunch of additions; it is the last version compatible with Julia 0.5.+. The idea is, once that version is in accepted in METADATA, this PR can be merged and it will tagged as v0.6.0. This supports Julia 0.6.0+ and above. Tests are passing.

@lbenet
Copy link
Member Author

lbenet commented Oct 9, 2017

I have retouched and updated some parts of the docs. I think this is ready to be merged and tagged as 0.6, so we drop support to Julia 0.5.x. Do you agree @dpsanders ?

@coveralls
Copy link

coveralls commented Oct 9, 2017

Coverage Status

Coverage increased (+1.6%) to 97.11% when pulling 943dcfb on deprecations0.6 into 909689b on master.

@dpsanders
Copy link
Contributor

Yes, great, go ahead!

@coveralls
Copy link

coveralls commented Oct 9, 2017

Coverage Status

Coverage increased (+1.6%) to 97.11% when pulling 943dcfb on deprecations0.6 into 909689b on master.

@lbenet lbenet merged commit d2eedd7 into master Oct 9, 2017
@lbenet
Copy link
Member Author

lbenet commented Oct 9, 2017

Done! I just tagged and submitted the PR to METADAT.

@lbenet lbenet deleted the deprecations0.6 branch October 17, 2017 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants