-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: make the code citable #24
Comments
Hi Benoit, absolutely! I just did make you an admin of the repo. It might take an extra step because JuliaDiff often adds a layer. But if you accept the admin request, maybe you can try to get a DOI. Otherwise I can do it. Seems just a few steps. Best, Rob |
Hi Rob, Yes I just saw that you added me as a collaborator — Thank you, it's an honor! :) |
OK I "toggled the automatic preservation" of the repository on Zenodo, and the next step is to create a release. Should I tag a v4.0.0 release? Maybe there are other things that need to be changed before? |
Just noticed it! Yes, I'm perfectly ok to release v4.0.0. Let me quickly update the version field in Project.toml to reflect this version number. Although everybody says that field does nothing, I certainly have seen issues with it. My next step is to create a list (as an issue) of outstanding items we want to fix (basically as per your PRs), like documentation, more testing, functions that dropped out, etc. I'm assuming Zenodo will download a new copy for each new release. These days releasing a package update to METADATA takes typically less that 1 to 2 hours. |
What is your timeframe for publication? Let's prioritize items to what you feel most important for the publication. Version field update is done. |
I don't think the paper will be ready before this DOI 😅 |
Hi Benoit, is it your intention to tag version 4.0.0 or would you prefer me to do it? I think 4.0.0 is ok as it is (and folks can always go back using [email protected]). For the next few weeks I will have to split my time between StatisticalRethinking and HyperDualNumbers, hence my question about your timeline. |
Hi Rob, Oh I thought you were asking about the timeline because you wanted to make some revisions before releasing v4.0.0! I'll do it now since you are saying it's OK for you 😄 (I'll close this issue when the DOI is out there but I think this will be automatic) |
Actually I think I'll port the tests from DualNumbers first :) |
Hi Benoit,
That’s great.
I have been struggling today with getting a docs framework up and running. It’s not finding the doc elements for some reason, but the skeleton is there.
I have also updated the test_symata.jl script to show the expressions as used in the symbolic_derivative_list. I have moved the `include(“derivatives_list.jl”)` to HyperDualNumbers.jl. What is the intention of the `symbolic_derivatives() = symbolic_derivative_list` statement at the end derivatives_list.j? I’m asking because I was looking for a way to include the list in a nice format in the documentation.
Best,
Rob
[email protected]
… On Nov 22, 2018, at 17:56, Benoit Pasquier ***@***.***> wrote:
Actually I think I'll port the tests from DualNumbers first :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#24 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADL6Ea-PTeRrfhcurumpZfWDuYzXS3Xks5ux0e9gaJpZM4Ytnf->.
|
Hi Rob, the I have been asking a few questions related to the issues here and other "todos" (asking on the Julia slack) and I was pointed to this nice work in progress from Jarett Revels: https://discourse.julialang.org/t/chainrules-replacing-diffrules-in-the-julia-ad-world/17608 |
Hi Benoit,
Agreed, let’s for a while at least use your list and revisit this say in the spring of next year.
ChainRules.jl looks very interesting. And indeed, I too consider myself a user of these kind of tools, not a developer! I had also read some updates on Cassette.jl in that context.
Also of interest in [YASGuide](https://github.com/jrevels/YASGuide <https://github.com/jrevels/YASGuide>). I always struggle with that.
Rob J Goedman
[email protected]
… On Nov 22, 2018, at 21:41, Benoit Pasquier ***@***.***> wrote:
Hi Rob,
the symbolic_derivatives() = symbolic_derivative_list was a copy-paste from DualNumbers.jl I think, where the point I assume was to export the function symbolic_derivatives() rather than the variable symbolic_derivative_list.
I have been asking a few questions related to the issues here and other "todos" (asking on the Julia slack) and I was pointed to this nice work in progress from Jarett Revels: https://discourse.julialang.org/t/chainrules-replacing-diffrules-in-the-julia-ad-world/17608 <https://discourse.julialang.org/t/chainrules-replacing-diffrules-in-the-julia-ad-world/17608>
I am not sure what to make of it yet (I feel like its out of my league when I read about all this) but it may be the way forward?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#24 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADL6IgG-Ool7WYtk7xaaIcWih65ljW8ks5ux3x2gaJpZM4Ytnf->.
|
Hi Benoit, Finally, the doc setup is fixed now. The coverage stuff is updated (jumped to 64%). The README layout is better. I really like how you ported the DualNumber tests to HyperDualNumbers. Very clean. How far do you think we should go with the docs? If we want to document the examples we should probably switch to Literate.jl, particularly is we would like to generate notebooks from the examples. If we want to primarily focus on REPL docs we can just flesh out the current place holders for Hyper(), eps1, etc. Best, |
Hi Rob, Nice work! Note that I can see the "dev" doc but I can't see the "stable" doc right now (404 when I click on the "stable" badge). I haven't had time to really dig into Literate.jl, so I am unsure how we should use it. Is there a package out there using Literate.jl to generate both the docs and notebooks (that you had in mind)? Or did you have a plan to structure it? |
Hi Benoit,
“stable” will show up once we do a new release, so in our case “stable” will point to v4.0.0.
With Literate.jl, good examples are DynamicHMCExamples.jl and JuaFEM.jl. StatisticalRethinking.jl is “my” test ground, but not quite there. Basically I defined .jl scripts in subdirectories of the chapters directory (00, 02, 03, …) and I use Literate to generate the actual snippets referred to in the book and at the same time generate .md docs and notebooks from the scripts in chapters.
We can decide later if this is useful for HyperDualNumbers.
Rob J Goedman
[email protected]
… On Nov 25, 2018, at 21:31, Benoit Pasquier ***@***.***> wrote:
Hi Rob,
Nice work!
Note that I can see the "dev" doc but I can't see the "stable" doc right now (404 when I click on the "stable" badge).
I haven't had time to really dig into Literate.jl, so I am unsure how we should use it. Is there a package out there using Literate.jl to generate both the docs and notebooks (that you had in mind)? Or did you have a plan to structure it?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#24 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADL6JzunzkuQik5nnZZ7as7y7Fdgzi1ks5uy26bgaJpZM4Ytnf->.
|
Hi Rob,
The reason I have been using this package is to use it in a paper I am working on. Right now I can simply refer to the repo's URL, but it would be better if the repo had a DOI to refer to. I have never done this myself but GitHub has guidelines for that. If you think this is a good idea, I will try to do it for this package! :)
Cheers!
The text was updated successfully, but these errors were encountered: