Support complex output in derivative
#583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 29, 2022
moble
added a commit
to moble/Quaternionic.jl
that referenced
this pull request
May 19, 2022
`ForwardDiff` [recently added](JuliaDiff/ForwardDiff.jl#583) support for complex-valued functions of real arguments, which demonstrates the (presumably) right way to support geometric-algebra-valued functions, including quaternion-valued functions. I was on roughly the right track, but the default method should return 0, and the specific methods of quaternions over `Dual`s should have extracted the `partials` field of each components. This implements that approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the differentiation of real->complex functions, which is unambiguous and not tricky (unlike complex->something)