Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert SIMD.jl usage #569

Merged
merged 3 commits into from
Dec 13, 2021
Merged

Revert SIMD.jl usage #569

merged 3 commits into from
Dec 13, 2021

Conversation

KristofferC
Copy link
Collaborator

I am a bit uneasy about putting this in a release. I think we need more downstream testing first.

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2021

Codecov Report

Merging #569 (7dbd072) into master (01a056d) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #569      +/-   ##
==========================================
- Coverage   85.38%   85.29%   -0.09%     
==========================================
  Files           9        9              
  Lines         869      857      -12     
==========================================
- Hits          742      731      -11     
+ Misses        127      126       -1     
Impacted Files Coverage Δ
src/dual.jl 74.24% <ø> (-0.60%) ⬇️
src/partials.jl 84.34% <100.00%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01a056d...7dbd072. Read the comment docs.

@KristofferC KristofferC merged commit 43ef860 into master Dec 13, 2021
KristofferC added a commit that referenced this pull request Dec 13, 2021
This reverts commit 43ef860, reversing
changes made to 01a056d.
KristofferC added a commit that referenced this pull request Aug 14, 2023
This reverts commit 43ef860, reversing
changes made to 01a056d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants