Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use specified threshold instead of DEFAULT_CHUNK_THRESHOLD in pickchunksize #552

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

chriselrod
Copy link
Contributor

No description provided.

Copy link
Collaborator

@KristofferC KristofferC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow..

@chriselrod
Copy link
Contributor Author

Wow..

Git blame says it's been like this for 4 years!

@chriselrod chriselrod closed this Nov 2, 2021
@chriselrod chriselrod reopened this Nov 2, 2021
@chriselrod
Copy link
Contributor Author

Is this test always so unreliable?

Error During Test at /home/runner/work/ForwardDiff.jl/ForwardDiff.jl/test/DualTest.jl:400
  Test threw exception
  Expression: dual_isapprox(NESTED_FDNUM ^ PRIMAL, exp(PRIMAL * log(NESTED_FDNUM)))
  DomainError with -8.830391984918102e18:

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2021

Codecov Report

Merging #552 (f483f2e) into master (9ec5e6b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
+ Coverage   85.10%   85.13%   +0.02%     
==========================================
  Files           9        9              
  Lines         826      841      +15     
==========================================
+ Hits          703      716      +13     
- Misses        123      125       +2     
Impacted Files Coverage Δ
src/prelude.jl 36.36% <100.00%> (-1.14%) ⬇️
src/apiutils.jl 100.00% <0.00%> (ø)
src/jacobian.jl 99.29% <0.00%> (+0.01%) ⬆️
src/gradient.jl 98.90% <0.00%> (+0.03%) ⬆️
src/partials.jl 84.34% <0.00%> (+0.13%) ⬆️
src/dual.jl 73.51% <0.00%> (+0.20%) ⬆️
src/config.jl 87.27% <0.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ec5e6b...f483f2e. Read the comment docs.

@KristofferC
Copy link
Collaborator

Yes, they are.

@KristofferC KristofferC merged commit 4ac0e94 into JuliaDiff:master Nov 4, 2021
@chriselrod chriselrod deleted the pickchunksizethreshold branch November 4, 2021 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants