convert for nested duals sharing tags (#711)

Co-authored-by: chriselrod <[email protected]>
JuliaDiff · Oct 30, 2024 · 7e9d778 · 7e9d778
1 parent 826d919
commit 7e9d778
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/src/dual.jl b/src/dual.jl
@@ -467,6 +467,7 @@ for R in (AbstractIrrational, Real, BigFloat, Bool)
 end
 
 @inline Base.convert(::Type{Dual{T,V,N}}, d::Dual{T}) where {T,V,N} = Dual{T}(V(value(d)), convert(Partials{N,V}, partials(d)))
+@inline Base.convert(::Type{Dual{T,Dual{T,V,M},N}}, d::Dual{T,V,M}) where {T,V,N,M} = Dual{T}(d, Partials{N,Dual{T,V,M}}(zero_tuple(NTuple{N,Dual{T,V,M}})))
 @inline Base.convert(::Type{Dual{T,V,N}}, x) where {T,V,N} = Dual{T}(V(x), zero(Partials{N,V}))
 @inline Base.convert(::Type{Dual{T,V,N}}, x::Number) where {T,V,N} = Dual{T}(V(x), zero(Partials{N,V}))
 Base.convert(::Type{D}, d::D) where {D<:Dual} = d

diff --git a/test/DualTest.jl b/test/DualTest.jl
@@ -637,6 +637,8 @@ end
     @test typeof(dfmax) === typeof(d1)
     @test isfinite(dfmin)
     @test isfinite(dfmax)
+
+  @test floatmin(Dual{Nothing, ForwardDiff.Dual{Nothing, Float64, 2}, 1}) === Dual{Nothing}(Dual{Nothing}(floatmin(Float64),0.0,0.0),Dual{Nothing}(0.0,0.0,0.0))
 end
 
 @testset "Integer" begin