You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As @sethaxen pointed out in #133, #131 accidentally disabled a number of tests, and introduced a weird bug. This PR currently resolves the first of these problems, and I'm presently working on the second.
@sethaxen could you confirm that this resolves the problem? I'm quite nervous about this because I don't really understand what's going on 😬 .
Well this is bizarre. Before it was correct for Adjoint and Composite differentials but conjugated for Matrix. Now this is correct for Matrix and Adjoint differentials but is conjugated for Composite
Oooooh, not it wasn't. Composite has always been wrong for Adjoint. ChainRules worked around that by checking that the pullback produced the same output for Matrix and Composite cotangents but only passed the Matrix to rrule_test.
I think then this looks good to go.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @sethaxen pointed out in #133, #131 accidentally disabled a number of tests, and introduced a weird bug. This PR currently resolves the first of these problems, and I'm presently working on the second.