Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix depwarn on 0.6 due to vectorized functions #40

Merged
merged 3 commits into from
Sep 11, 2016
Merged

Fix depwarn on 0.6 due to vectorized functions #40

merged 3 commits into from
Sep 11, 2016

Conversation

yuyichao
Copy link
Contributor

Also use tuple type instead of tuples (Ref JuliaLang/julia#18444 and it's easier to infer in general)

@mlubin
Copy link
Contributor

mlubin commented Sep 11, 2016

Could you also update travis here? Thanks!

@yuyichao
Copy link
Contributor Author

And done.

@mlubin mlubin merged commit 945df59 into JuliaDiff:master Sep 11, 2016
@yuyichao yuyichao deleted the vectorize branch September 11, 2016 18:50
@tkelman
Copy link

tkelman commented Nov 24, 2016

Note that this caused value to start being exported which caused EmpiricalRisks.jl's tests to start failing - http://pkg.julialang.org/logs/EmpiricalRisks_0.4.log

@mlubin
Copy link
Contributor

mlubin commented Nov 25, 2016

That's unfortunate, value should not be exported. I'll accept PRs to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuyichao @mlubin @tkelman