-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Jacobian and Hessian preparation #535
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #535 +/- ##
==========================================
- Coverage 98.64% 98.63% -0.02%
==========================================
Files 106 106
Lines 4572 4606 +34
==========================================
+ Hits 4510 4543 +33
- Misses 62 63 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gdalle
changed the title
Avoid slicing the whole Jacobian if batch size does not divide total size
Improve Jacobian and Hessian preparation
Oct 3, 2024
gdalle
commented
Oct 3, 2024
DifferentiationInterface/ext/DifferentiationInterfaceForwardDiffExt/utils.jl
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versions
DI source
pick_batchsize
withVal(B)
instead ofB
Val(B)
to the Jacobian and Hessian preparators with a function barrier. Do the same for sparse Jacobians and Hessians.DI extensions
Val(16)
Val(C)
if pre-selected inAutoForwardDiff
. I tried to do the same forChunk{C}
but it is forbidden to have chunks larger than the input size.DIT source
preparation_type_stability
toDIT.test_differentiation
which runsJET.@test_opt
on the preparation operatorDI and DIT tests
preparation_type_stability
for trivial dense and sparse backends