-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove rule for identity #64
Conversation
We need it in the symbolic stack because |
Ok, we should add some test then. I don't see how the default fallback for |
Oh I see what you're saying. idenity(f::Dual) = Dual(identity(f.val), identity(f.val) * f.der) == Dual(identity(f.val), identity(f.val)) == identity(f::Any) For some reason I was thinking the derivative of the identity is 1, so |
Nabla failures unrelated @oxinabox ? |
Nabla failures unrelated. |
I agree this is safe to remove. |
If it hurts Symbolics then we'll find out quickly so it's good. Rip off the bandaid. |
This one causes quite a lot of invalidations (SciML/DiffEqBase.jl#698 (comment)). It was added in #54 but it is unclear why it was added.
Is it needed for anything?