Comment out trinary rules #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
==========================================
- Coverage 94.07% 93.93% -0.14%
==========================================
Files 2 2
Lines 135 132 -3
==========================================
- Hits 127 124 -3
Misses 8 8
Continue to review full report at Codecov.
|
This was referenced Jul 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the 3-argument rules introduced in #54
While they appear to be explicitly supported by this package, they are violently rejected by ForwardDiff, it turns out.
According to https://github.com/SciML/ColPrac#accidental-breaking-releases the right path is to immediately tag a patch version without the problematic changes.
I have checked locally that ForwardDiff does load & run things, with this branch.