Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add downstream tests #34

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Add downstream tests #34

merged 2 commits into from
Mar 21, 2024

Conversation

devmotion
Copy link
Member

Fixes #33.

The PR adds downstream tests with the GHA workflow used in SciML, ChainRulesCore, DiffRules etc. for ForwardDiff, ReverseDiff, AbstractDifferentiation, and LogDensityProblemsAD (we can easily add more but these seemed to be the most relevant at first glance).

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.84%. Comparing base (91614bb) to head (51f2582).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #34   +/-   ##
=======================================
  Coverage   86.84%   86.84%           
=======================================
  Files           1        1           
  Lines          76       76           
=======================================
  Hits           66       66           
  Misses         10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devmotion
Copy link
Member Author

The ReverseDiff error on Julia 1.10 (due to vcat) is known and the Zygote error in AbstractDifferentiation (due to try-catch) is not relevant as it does not involve DiffResults.

Copy link
Member

@gdalle gdalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing, I didn't even know we could do that!

.github/workflows/IntegrationTest.yml Outdated Show resolved Hide resolved
.github/workflows/IntegrationTest.yml Show resolved Hide resolved
.github/workflows/IntegrationTest.yml Outdated Show resolved Hide resolved
.github/workflows/IntegrationTest.yml Show resolved Hide resolved
@devmotion devmotion merged commit fcf7858 into master Mar 21, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downstream tests
2 participants