Handle RuleConfig and move to new world #4
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the companion to JuliaDiff/ChainRulesCore.jl#363
which was breaking for this, but only in a silly way.
This PR does 3 things.
1 . corrects the incorrect definition of the frule fallback
That ChainRulesCore PR as a complete side change corrected the fallback from
frule(f, args...)
tofrule(dargs, f, args...)
.Which never really mattered since everything was
Any
typed, but still was wrong, and turned on CROG (ChainRulesOverloadGeneration) depended on that2. drop support for CRC (ChainRulesCore) 0.9 and remove deprecated things
We needed to drop that so we can talk about RuleConfigs for next part
3. Filter out rules that require RuleConfig
Technically we can ignore these, adding the config wasn't actually breaking.
But it does make the hook function spew out a ton of warnings.
So we would rather not.
In some future PR we will bring them back.
but will need to think a bit about the API.
The user already does a lot of filtering, so probably we will want to let them do this filtering also.