Define a bunch of zero_tangents that should just NoTangent #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| zero_tangent(::Core.Compiler.AbstractInterpreter) = NoTangent() | ||
| zero_tangent(::Core.Compiler.InstructionStream) = NoTangent() | ||
| zero_tangent(::Core.CodeInfo) = NoTangent() | ||
| zero_tangent(::Core.MethodInstance) = NoTangent() |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| zero_tangent(::Core.MethodInstance) = NoTangent() | |
| zero_tangent(::Core.MethodInstance) = NoTangent() |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #662 +/- ##
==========================================
- Coverage 94.26% 93.80% -0.47%
==========================================
Files 15 15
Lines 977 985 +8
==========================================
+ Hits 921 924 +3
- Misses 56 61 +5 ☔ View full report in Codecov by Sentry. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
… that constructable
test/tangent_types/abstract_zero.jl
Outdated
Comment on lines
187
to
188
| zero_tangent(Dict{Int, Float64}(1=>2.4)), | ||
| Tangent{Dict{Int,Float64}}(Dict{Int, Float64}()) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| zero_tangent(Dict{Int, Float64}(1=>2.4)), | |
| Tangent{Dict{Int,Float64}}(Dict{Int, Float64}()) | |
| zero_tangent(Dict{Int,Float64}(1 => 2.4)), | |
| Tangent{Dict{Int,Float64}}(Dict{Int,Float64}()), |
test/tangent_types/abstract_zero.jl
Outdated
Comment on lines
191
to
192
| zero_tangent(Base.PersistentDict(1=>2.4)), | ||
| Tangent{Base.PersistentDict{Int,Float64}}(Dict{Int, Float64}()) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| zero_tangent(Base.PersistentDict(1=>2.4)), | |
| Tangent{Base.PersistentDict{Int,Float64}}(Dict{Int, Float64}()) | |
| zero_tangent(Base.PersistentDict(1 => 2.4)), | |
| Tangent{Base.PersistentDict{Int,Float64}}(Dict{Int,Float64}()), |
| Tangent{Base.PersistentDict{Int,Float64}}(Dict{Int, Float64}()) | ||
| ) | ||
|
|
||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
Comment on lines
+187
to
+188
| zero_tangent(Dict{Int, Float64}(1 => 2.4)), | ||
| Tangent{Dict{Int,Float64}}(Dict{Int, Float64}()) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| zero_tangent(Dict{Int, Float64}(1 => 2.4)), | |
| Tangent{Dict{Int,Float64}}(Dict{Int, Float64}()) | |
| zero_tangent(Dict{Int,Float64}(1 => 2.4)), | |
| Tangent{Dict{Int,Float64}}(Dict{Int,Float64}()), |
| if isdefined(Base, :PersistentDict) | ||
| @test ==( | ||
| zero_tangent(Base.PersistentDict(1 => 2.4)), | ||
| Tangent{Base.PersistentDict{Int,Float64}}(Dict{Int, Float64}()) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| Tangent{Base.PersistentDict{Int,Float64}}(Dict{Int, Float64}()) | |
| Tangent{Base.PersistentDict{Int,Float64}}(Dict{Int,Float64}()), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do vaguely wonder if we should just preemptively walk things and if we don't find an AbstractFloat element always return
NoTangent.But for now I am just marking a bunch of stuff that has no tangent space as
zero_tangent(x)=NoTangent()Also fixes
AbstractDictthough we have never properly implemented dict support in AD.