Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kwarg support to at-nondifferentiable #217

Merged
merged 2 commits into from
Sep 11, 2020
Merged

Add kwarg support to at-nondifferentiable #217

merged 2 commits into from
Sep 11, 2020

Conversation

oxinabox
Copy link
Member

Follow up to #207
fixes #216

Following this we just always accept kw-args and then just allways pass them on

test/rule_definition_tools.jl Outdated Show resolved Hide resolved
end

@testset "setting kw" begin
@assert kw_demo(1.5; kw=3.0) == 4.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we're doing an @assert here and not @test?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah,
I used @assert to test my test code
and @test to test my source code

Co-authored-by: mattBrzezinski <[email protected]>
@oxinabox oxinabox merged commit 39f1caf into master Sep 11, 2020
@oxinabox oxinabox deleted the ox/nondiff_kw branch September 11, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyword arguments for @non_differentiable
3 participants