Merge pull request #667 from JuliaDiff/ox/nobool

Bools have no tangent
JuliaDiff · Mar 1, 2024 · 7730f38 · 7730f38
2 parents 75e84bc + 4b2c810
commit 7730f38
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/src/tangent_types/abstract_zero.jl b/src/tangent_types/abstract_zero.jl
@@ -111,6 +111,7 @@ In general, it is more likely to produce a structural tangent.
 function zero_tangent end
 
 zero_tangent(x::Number) = zero(x)
+zero_tangent(x::Bool) = NoTangent()
 
 function zero_tangent(x::MutableTangent{P}) where {P}
     zb = backing(zero_tangent(backing(x)))
@@ -178,6 +179,8 @@ end
 
 # Sad heauristic methods we need because of unassigned values
 guess_zero_tangent_type(::Type{T}) where {T<:Number} = T
+guess_zero_tangent_type(::Type{Bool}) = NoTangent()
+
 guess_zero_tangent_type(::Type{T}) where {T<:Integer} = typeof(float(zero(T)))
 function guess_zero_tangent_type(::Type{<:Array{T,N}}) where {T,N}
     return Array{guess_zero_tangent_type(T),N}

diff --git a/test/tangent_types/abstract_zero.jl b/test/tangent_types/abstract_zero.jl
@@ -165,6 +165,8 @@ end
     @testset "basics" begin
         @test zero_tangent(1) === 0
         @test zero_tangent(1.0) === 0.0
+        @test zero_tangent(true) === NoTangent()
+
         mutable struct MutDemo
             x::Float64
         end