Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to make Zygote work with thunks (using this PR FluxML/Zygote.jl#966).
MWE:
Returns:
The reason this happens is because
ZBack
no longer unthunksThunks
when being called (inwrap_chainrules_output
), so rrule for eachcol receivesdy
as:Where each element of
Vector
is produced bynorm_pullback_2
.While previously due to unthunking in
ZBack
we'd get fordy
:And so the execution of
∇eachslice
woudn't terminate here.