Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy JuliaFormatter config from ChainRulesCore.jl #744

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

hyrodium
Copy link
Contributor

@hyrodium hyrodium commented Oct 1, 2023

This PR adds JuliaFormatter config. See JuliaDiff/ChainRulesCore.jl#482 for more information.
I haven't formatted the current source so as not to make conflicts with other PRs.

@oxinabox
Copy link
Member

oxinabox commented Oct 2, 2023

I am not 100% convinced a formatter is a good idea. but we should be consistent about having one across the chainrules family of packages. So I am merging this

@oxinabox oxinabox merged commit ec9b281 into JuliaDiff:main Oct 2, 2023
@oxinabox
Copy link
Member

oxinabox commented Oct 2, 2023

thanks

@hyrodium hyrodium deleted the feature/JuliaFormatter branch October 2, 2023 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants