Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow N-dimensional arrays in sort rules #735

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Allow N-dimensional arrays in sort rules #735

wants to merge 2 commits into from

Conversation

pxl-th
Copy link
Contributor

@pxl-th pxl-th commented Aug 30, 2023

No description provided.

@mcabbott
Copy link
Member

I think the reason these weren't added initially is that sortperm says "The method accepting dims requires at least Julia 1.9."

@pxl-th
Copy link
Contributor Author

pxl-th commented Aug 30, 2023

Restricted tests to 1.9+. Otherwise it does not break anything.

@oxinabox oxinabox requested a review from mcabbott August 31, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcabbott mcabbott Awaiting requested review from mcabbott

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pxl-th @mcabbott