Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bad non-differentiable #604

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Remove bad non-differentiable #604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
098d6a8
Remove bad rules
willtebbutt Mar 28, 2022
cae34fa
Bump patch
willtebbutt Mar 28, 2022
108afcb
Add back in some more specific methods
willtebbutt Mar 29, 2022
40c14ce
More rules
willtebbutt Mar 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "ChainRules"
uuid = "082447d4-558c-5d27-93f4-14fc19e9eca2"
version = "1.28.1"
version = "1.28.2"

[deps]
ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"
Expand Down
7 changes: 3 additions & 4 deletions src/rulesets/Random/random.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,9 @@ end
@non_differentiable rand(::Type{<:Real}, ::Integer...)
@non_differentiable rand(::Integer...)

# There are many different 1-3 arg methods, but not varargs
@non_differentiable rand!(::Any)
@non_differentiable rand!(::Any, ::Any)
@non_differentiable rand!(::Any, ::Any, ::Any)
@non_differentiable rand!(::AbstractArray)
@non_differentiable rand!(::AbstractRNG, ::AbstractArray)
@non_differentiable rand!(::AbstractRNG, ::AbstractArray, ::Type)

@non_differentiable randexp(::Any...)

Expand Down