Fix Composite of SVD #390
Merged
Fix Composite of SVD #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethaxen
approved these changes
Mar 24, 2021
This was referenced Mar 24, 2021
|
I've modernised the tests from the manual finite differences tests to the new |
sethaxen
approved these changes
Mar 24, 2021
Codecov Report
@@ Coverage Diff @@
## master #390 +/- ##
===========================================
- Coverage 98.45% 87.76% -10.70%
===========================================
Files 20 20
Lines 1745 1291 -454
===========================================
- Hits 1718 1133 -585
- Misses 27 158 +131
Continue to review full report at Codecov.
|
added 2 commits
March 24, 2021 20:22
bors bot
added a commit
to FluxML/Zygote.jl
that referenced
this pull request
Mar 25, 2021
926: Canonicalize the Composite before changing it to a NamedTuple r=oxinabox a=mzgubic Closes #922. The issue occurs when the following are all true: 1) We have a struct with two differentiable fields 2) We need to accumulate the gradients with respect to both fields 3) The gradients that need to be accumulated both originate from an rrule In that case, the two gradients that originate from an rrule are `Composite`s with disjoint fields. When they are transformed to a `NamedTuple`, the Zygote internal representation of derivatives w.r.t. structs, these two `NamedTuple`s have disjoint sets of keys, and are not `accum`ulated correctly. By adding `canonicalize(x)`, the `Composite` gets explicit `Zero()` fields, which means the resulting `NamedTuple`s have the complete set of fields. ~~- blocked by JuliaDiff/ChainRules.jl#390 (tests only)~~ ~~- need to change compat once the above is merged~~ Co-authored-by: Miha Zgubic <[email protected]> Co-authored-by: Miha Zgubic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #389 , closes #106