Move Symmetric/Hermitian rules and tests to own file #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #322 +/- ##
=======================================
Coverage 97.46% 97.46%
=======================================
Files 17 18 +1
Lines 988 988
=======================================
Hits 963 963
Misses 25 25
Continue to review full report at Codecov.
|
|
Seems reasonable to me. Regarding version number: to my mind it still makes sense to bump the patch version -- my understanding of our policy is that any changes to |
willtebbutt
approved these changes
Dec 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in #193 (comment), this PR just moves the rules for functions of
Symmetric/Hermitianto their own file and does the same for the tests. Not only does this mirror the structure of LinearAlgebra (where these methods are defined insymmetric.jl), but with #193 and as mentioned in #321, more specializations are coming for these matrices, and this will makestructured.jlless cluttered.This PR does not make any changes to functionality and only exists so that these future PRs are cleanly separated from the reorg. As such I don't think it needs a bump to version number.