Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eigen tests fail on nightly #422

Closed
simeonschaub opened this issue May 28, 2021 · 1 comment · Fixed by JuliaLang/julia#41132
Closed

eigen tests fail on nightly #422

simeonschaub opened this issue May 28, 2021 · 1 comment · Fixed by JuliaLang/julia#41132
Labels
testing Related to tests

Comments

@simeonschaub
Copy link
Member

See for example https://github.com/JuliaDiff/ChainRules.jl/pull/421/checks?check_run_id=2697576261:

Test Summary:                                            |  Pass  Fail  Broken  Total
ChainRules                                               | 23210     3       4  23217
  rulesets                                               | 23210     3       4  23217
    Base                                                 |  6510             4   6514
    Statistics                                           |    12                   12
    LinearAlgebra                                        | 16643     3          16646
      dense                                              |   585                  585
      norm functions                                     |  1592                 1592
      normalize                                          |    90                   90
      matrix functions                                   |   133                  133
      Structured Matrices                                |   412                  412
      Symmetric/Hermitian rules                          |  3556                 3556
      Factorizations                                     |   505     3            508
        lu decomposition                                 |   159                  159
        svd                                              |   226                  226
        eigendecomposition                               |   104     3            107
          eigen/eigen!                                   |    67     3             70
            eigen!(::Matrix{Float64}) frule              |     7                    7
            eigen!(::Matrix{ComplexF64}) frule           |     4     2              6
              tangents are real when outputs are         |     1                    1
            eigen(::Matrix{Float64}) rrule               |     8                    8
            eigen(::Matrix{ComplexF64}) rrule            |     6     1              7
            normalization/phase functions are idempotent |     4                    4
            normalization/phase functions are idempotent |     4                    4
            hermitian matrices                           |    34                   34
          eigvals/eigvals!                               |    37                   37
        cholesky                                         |    16                   16
      BLAS                                               |  9354                 9354
      LAPACK                                             |   416                  416
    Random                                               |    45                   45
    packages                                             |                      No tests
ERROR: LoadError: Some tests did not pass: 23210 passed, 3 failed, 0 errored, 4 broken.
@simeonschaub simeonschaub added the testing Related to tests label May 28, 2021
@simeonschaub simeonschaub mentioned this issue May 28, 2021
Merged
simeonschaub added a commit that referenced this issue Jun 2, 2021
@simeonschaub
fix #422: nightly failures due to instabilities
97ecc89
simeonschaub added a commit that referenced this issue Jun 2, 2021
@simeonschaub
fix #422: nightly failures due to instabilities
7d18f6f
@simeonschaub simeonschaub changed the title numeric instabilities in eigen tests on nightly eigen tests fail on nightly Jun 8, 2021
simeonschaub added a commit to JuliaLang/julia that referenced this issue Jun 8, 2021
@simeonschaub
fix equality of eigen factorizations
c430b0d 
At least the newly added field `rcondv` may contain `undef` values, so
these can cause the same eigen factorizations not to compare equal. Not
100% sure whether the other fields should be ignored as well, but since
we didn't have them before, it seems at least consistent to ignore them
here.

fixes JuliaDiff/ChainRules.jl#422
@simeonschaub simeonschaub mentioned this issue Jun 8, 2021
Merged
simeonschaub added a commit to JuliaLang/julia that referenced this issue Jun 8, 2021
@simeonschaub
fix equality of eigen factorizations
53e8d86 
At least the newly added field `rcondv` may contain `undef` values, so
these can cause the same eigen factorizations not to compare equal. Not
100% sure whether the other fields should be ignored as well, but since
we didn't have them before, it seems at least consistent to ignore them
here.

fixes JuliaDiff/ChainRules.jl#422
simeonschaub added a commit to JuliaLang/julia that referenced this issue Jun 14, 2021
@simeonschaub
fix equality of eigen factorizations (#41132)
bc3ce48 
At least the newly added field `rcondv` may contain `undef` values, so
these can cause the same eigen factorizations not to compare equal. Not
100% sure whether the other fields should be ignored as well, but since
we didn't have them before, it seems at least consistent to ignore them
here.

fixes JuliaDiff/ChainRules.jl#422
@simeonschaub
Copy link
Member Author

Will likely take a while for nightlies to propagate through, but then we should hopefully have passing tests on nightly again.

@simeonschaub simeonschaub mentioned this issue Jun 15, 2021
Merged
KristofferC pushed a commit to JuliaLang/julia that referenced this issue Jun 17, 2021
@simeonschaub @KristofferC
fix equality of eigen factorizations (#41132)
9388531 
At least the newly added field `rcondv` may contain `undef` values, so
these can cause the same eigen factorizations not to compare equal. Not
100% sure whether the other fields should be ignored as well, but since
we didn't have them before, it seems at least consistent to ignore them
here.

fixes JuliaDiff/ChainRules.jl#422

(cherry picked from commit bc3ce48)
johanmon pushed a commit to johanmon/julia that referenced this issue Jul 5, 2021
@simeonschaub @johanmon
fix equality of eigen factorizations (JuliaLang#41132)
fcd8d18 
At least the newly added field `rcondv` may contain `undef` values, so
these can cause the same eigen factorizations not to compare equal. Not
100% sure whether the other fields should be ignored as well, but since
we didn't have them before, it seems at least consistent to ignore them
here.

fixes JuliaDiff/ChainRules.jl#422
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing Related to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix equality of eigen factorizations JuliaLang/julia
1 participant
@simeonschaub