remove duplicate _diagm_back definition

JuliaDiff · Oct 12, 2023 · b7bd291 · b7bd291
1 parent 8c3467f
commit b7bd291
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/src/rulesets/LinearAlgebra/structured.jl b/src/rulesets/LinearAlgebra/structured.jl
@@ -96,7 +96,7 @@ end
 
 function _diagm_back(p, ȳ)
     k, v = p
-    d = diag(unthunk(ȳ), k)[1:length(v)] # handle if diagonal was smaller than matrix
+    d = diag(unthunk(ȳ), k)[eachindex(v)] # handle if diagonal was smaller than matrix
     return Tangent{typeof(p)}(second = d)
 end
 

diff --git a/src/rulesets/SparseArrays/sparsematrix.jl b/src/rulesets/SparseArrays/sparsematrix.jl
@@ -160,10 +160,3 @@ function rrule(::typeof(spdiagm), v::AbstractVector)
     end
     return spdiagm(v), spdiagm_pullback
 end
-
-
-function _diagm_back(p, ȳ)
-    k, v = p
-    d = diag(unthunk(ȳ), k)[eachindex(v)]  # handle if diagonal was smaller than matrix
-    return Tangent{typeof(p)}(second = d)
-end