Fix clamp rule when max < min

JuliaDiff · Jul 24, 2024 · a49ef5d · a49ef5d
1 parent dba6cb5
commit a49ef5d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/rulesets/Base/base.jl b/src/rulesets/Base/base.jl
@@ -186,7 +186,7 @@ end
         islow = x < low,
         ishigh = high < x,
     ),
-    (!(islow | ishigh), islow, ishigh),
+    (!(islow | ishigh), islow & (low < high), ishigh),
 )
 @scalar_rule x \ y (-(Ω / x), one(y) / x)
 

diff --git a/test/rulesets/Base/base.jl b/test/rulesets/Base/base.jl
@@ -199,6 +199,10 @@ end
         # to right
         test_frule(clamp, 4., 2., 3.)
         test_rrule(clamp, 4., 2., 3.)
+
+        # max < min
+        test_frule(clamp, 3., 4., 2.)
+        test_rrule(clamp, 3., 4., 2.)
     end
 
     @testset "rounding" begin