Add promotion rules (belong in ChainRulesCore)

JuliaDiff · Sep 16, 2024 · 45f00a5 · 45f00a5
1 parent aa58c9b
commit 45f00a5
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/rulesets/Base/indexing.jl b/src/rulesets/Base/indexing.jl
@@ -284,6 +284,10 @@ end
 
 _zero_fill!(dx::AbstractArray) = fill!(dx, zero(eltype(dx)))
 
+# Belong in ChainRulesCore
+Base.promote_type(T::Type{<:Number}, S::Type{<:AbstractZero}) = T
+Base.promote_type(T::Type{<:AbstractZero}, S::Type{<:Number}) = S
+
 function rrule(::typeof(∇eachslice), dys, x, vd::Val)
     function ∇∇eachslice(dz_raw)
         dz = unthunk(dz_raw)