Add some projectors

JuliaDiff · Feb 12, 2022 · 0cb446f · 0cb446f
1 parent 55d64f1
commit 0cb446f
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/rulesets/Base/fastmath_able.jl b/src/rulesets/Base/fastmath_able.jl
@@ -11,7 +11,8 @@ let
         ## sin
         function rrule(::typeof(sin), x::CommutativeMulNumber)
             sinx, cosx = sincos(x)
-            sin_pullback(Δy) = (NoTangent(), cosx' * Δy)
+            project_x = ProjectTo(x)
+            sin_pullback(Δy) = (NoTangent(), project_x(cosx' * Δy))
             return (sinx, sin_pullback)
         end
 
@@ -23,7 +24,8 @@ let
         ## cos
         function rrule(::typeof(cos), x::CommutativeMulNumber)
             sinx, cosx = sincos(x)
-            cos_pullback(Δy) = (NoTangent(), -sinx' * Δy)
+            project_x = ProjectTo(x)
+            cos_pullback(Δy) = (NoTangent(), -project_x(sinx' * Δy))
             return (cosx, cos_pullback)
         end
 
@@ -61,7 +63,7 @@ let
             project_x = ProjectTo(x)
             function inv_pullback(ΔΩ)
                 Ω′ = conj(Ω)
-                return NoTangent(), project_x(Ω′ * -ΔΩ * Ω′)
+                return NoTangent(), -project_x(Ω′ * ΔΩ * Ω′)
             end
             return Ω, inv_pullback
         end