Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect splatting kwarg prep #403

Merged
merged 2 commits into from
Jun 7, 2020
Merged

Detect splatting kwarg prep #403

merged 2 commits into from
Jun 7, 2020

Conversation

timholy
Copy link
Member

@timholy timholy commented Jun 4, 2020

We were failing to detect kw functions that accepted vararg positional args.

@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #403 into master will decrease coverage by 0.00%.
The diff coverage is 88.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
- Coverage   87.72%   87.72%   -0.01%     
==========================================
  Files          11       11              
  Lines        2013     2037      +24     
==========================================
+ Hits         1766     1787      +21     
- Misses        247      250       +3     
Impacted Files Coverage Δ
src/utils.jl 84.93% <84.61%> (-0.02%) ⬇️
src/commands.jl 92.98% <91.66%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fc130d...31802d5. Read the comment docs.

@timholy
Copy link
Member Author

timholy commented Jun 7, 2020

Any objections?

@KristofferC
Copy link
Member

Didn't look too carefully but the test shows it works so LGTM. It is a bit unfortunate that we need to have so much complicated code to match but it is what it is. Perhaps in the future we could think about if the compiler could emit som helpful markers in the lowered code or something to help with stuff like this.

@timholy
Copy link
Member Author

timholy commented Jun 7, 2020

I think the ultimate answer is JuliaLang/julia#31162, but perhaps in its absence we could come up with something else?

@timholy timholy merged commit 6c0036c into master Jun 7, 2020
@timholy timholy deleted the teh/better_kwmatch branch June 7, 2020 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants