Suggestion: Do not mark BUILTIN_FILE as a precompilation dependency #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkf
changed the title
Codecov Report
@@ Coverage Diff @@
## master #271 +/- ##
======================================
Coverage 85.6% 85.6%
======================================
Files 14 14
Lines 2036 2036
======================================
Hits 1743 1743
Misses 293 293
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #271 +/- ##
======================================
Coverage 85.6% 85.6%
======================================
Files 14 14
Lines 2036 2036
======================================
Hits 1743 1743
Misses 293 293
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include(BUILTIN_FILE)is problematic becauseBUILTIN_FILEis recorded as a dependency of the precompilation file. To see the problem, suppose JuliaInterpreter is precompiled for projectAand then for projectBusing the same Julia version. Now importing JuliaInterpreter for projectAagain triggers precompilation becauseBUILTIN_FILEis updated by projectB.This is not a major issue in standard Julia environment until JuliaLang/julia#27418 is solved. However, this problem can already be observed in
jlmwhich is a system image manager I wrote to solve the precompilation problem. It would be nice if JuliaInterpreter can go ahead and solve the problem before the precompilation problem is solved in Julia. Let me know if it makes sense to do so or there is a better way to fix it.