A grab-bag of correctness fixes #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those tests assume they are running from a particular directory
This should fix tests that check for the MethodError
This handles SlotNumbers (which can arise in `let` blocks) and hopefully the full set of allowed values for library resolution.
Some of these might work, but others result in undefined names, presumably due to confusion between the ones in Base and the ones in Core.Compiler. For now, punt by refusing to descend into Core.Compiler.
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
=========================================
- Coverage 71.54% 0% -71.55%
=========================================
Files 6 6
Lines 1135 1115 -20
=========================================
- Hits 812 0 -812
- Misses 323 1115 +792
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This collection of commits emerged from trying to address #13. With
julia --startup-file=no(so no extraneous packages are loaded), we now get throughtest/ambiguous.jland almost the first 1k lines ofstrings/basic.jl. I do not yet know if the failure to progress farther is a bug or just a performance problem.