Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWE for failures in file #106

Closed
macd opened this issue Mar 6, 2019 · 4 comments
Closed

MWE for failures in file #106

macd opened this issue Mar 6, 2019 · 4 comments

Comments

@macd
Copy link
Contributor

macd commented Mar 6, 2019

The first two errors are due to throwing the wrong exception. The third error has my new favorite error message: sigatomic_end called in non-sigatomic region

using JuliaInterpreter
include("utils.jl")

module file_test
    using Test
end

m = file_test

ex = quote
    @test_throws ArgumentError download("good", "ba\0d") # Thrown: UndefVarError
    @test_throws ArgumentError download("ba\0d", "good") # Thrown: UndefVarError
    n = tempname()
    w = open(n, "a")
    write(w, "A")
    flush(w)  #  sigatomic_end called in non-sigatomic region
    #close(w)
    #rm(n)
end

frame = JuliaInterpreter.prepare_thunk(m, ex)
JuliaInterpreter.finish_and_return!(JuliaStackFrame[], frame)
@KristofferC
Copy link
Member

I can't repro the UndefVarErrors:

> JuliaInterpreter.finish_and_return!(JuliaStackFrame[], frame)
  Test Passed
      Thrown: ArgumentError

@macd
Copy link
Contributor Author

macd commented Mar 6, 2019

Hmmm, I am using today's master and Ubuntu 18.04 on two different machines. (Intel Skull Canyon NUC and a Lenovo laptop ~4.5 years old) and it fails on both of them. Any setup issues that I may have bolluxed?

@KristofferC
Copy link
Member

I'm using Windows and 1.1.0 so maybe it has something to do with that?

timholy added a commit that referenced this issue Mar 6, 2019
REPL also uses sigatomic, but I don't expect to be interpreting REPL
anytime soon.
@timholy
Copy link
Member

timholy commented Mar 6, 2019

I tried Ubuntu 18.04 and can't repro the UndefVarErrors. The sigatomic issue will be fixed by #108.

@timholy timholy closed this as completed in 94f8834 Mar 6, 2019
timholy added a commit that referenced this issue Mar 6, 2019
Run all Base users of `sigatomic` in compiled mode. Fixes #106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants