Allow a Tuple{typeof(f),...} as root of ascend tree
#588
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #588 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 9 9
Lines 1556 1574 +18
======================================
- Misses 1556 1574 +18 ☔ View full report in Codecov by Sentry. |
|
I've been using this for a couple of hours and it's been great, so I think it's baked well enough to release. |
| for (a, b) in zip(info.argtyps, tt.parameters[2:end]) | ||
| a === b || return false |
There was a problem hiding this comment.
When iterating over a zip created from a Vector{Any}, objects of type Tuple{<:Any,<:Any} are created, which can sometimes lead to unnecessary specializations, especially when the vector contains Type objects.
Since we're only using ===, it shouldn't be a problem for this case, but it's something to be mindful of when working on Core.Compiler and other external abstract interpreters in the future.
There was a problem hiding this comment.
Yeah, I figured this case would be OK. I was leaning on the "self check" tests too, I admit!
Required for aviatesk/JET.jl#648 (comment)