Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypedSyntax.jl: drop old version support #553

Merged
merged 1 commit into from
Mar 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,17 +43,11 @@ jobs:
${{ runner.os }}-test-${{ env.cache-name }}-
${{ runner.os }}-test-
${{ runner.os }}-
- name: dev TypedSyntax
shell: julia --color=yes --project=. {0} # this is necessary for the next command to work on Windows
run: 'using Pkg; Pkg.develop(path=joinpath(pwd(), "TypedSyntax"))'
- uses: julia-actions/julia-buildpkg@v1
- uses: julia-actions/julia-runtest@v1
with:
check_bounds: 'auto'
coverage: 'false'
- name: TypedSyntax # run the tests of TypedSyntax (a subdir package)
if: ${{ matrix.os == 'ubuntu-latest' }}
run: julia --project=TypedSyntax -e 'using Pkg; Pkg.test(coverage=true)'
# - name: Coverage off # `empty_func` test doesn't work as intended with `coverage=true`
# if: ${{ matrix.os == 'ubuntu-latest' }}
# run: julia --project -e 'using Pkg; Pkg.test("Cthulhu"; coverage=false)'
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/TypedSyntaxCI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,10 @@ jobs:
fail-fast: false
matrix:
version:
- '1.6' # test LTS versions that are not supported by Cthulhu
- '1'
- '1.10.0'
- '1.11-nightly'
- 'nightly'
os:
- ubuntu-latest
arch:
Expand Down
8 changes: 3 additions & 5 deletions TypedSyntax/test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -527,11 +527,9 @@ include("test_module.jl")
@test node.typ === Type{Float64}

# UnionAll in signature (issue #409)
@static if VERSION ≥ v"1.9-"
tsn = TypedSyntaxNode(Core.kwcall, (NamedTuple, typeof(issorted), Vector{Int}))
sig, body = children(tsn)
@test has_name_typ(child(sig, 2), :itr, Vector{Int})
end
tsn = TypedSyntaxNode(Core.kwcall, (NamedTuple, typeof(issorted), Vector{Int}))
sig, body = children(tsn)
@test has_name_typ(child(sig, 2), :itr, Vector{Int})

# Empty `return` (issue #458)
tsn = TypedSyntaxNode(TSN.f458, ())
Expand Down
Loading