changes to adapt to compressed line table format #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
force-pushed
the
jn/invert-line-table
branch
from
d7379f1 to
71efc78
Compare
vtjnash
force-pushed
the
jn/invert-line-table
branch
from
71efc78 to
895eea4
Compare
vtjnash
force-pushed
the
jn/invert-line-table
branch
from
895eea4 to
8d49de6
Compare
vtjnash
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #526 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 9 9
Lines 1541 1545 +4
======================================
- Misses 1541 1545 +4 ☔ View full report in Codecov by Sentry. |
vtjnash
commented
Mar 7, 2024
aviatesk
force-pushed
the
jn/invert-line-table
branch
from
8d49de6 to
747619e
Compare
aviatesk
reviewed
Mar 20, 2024
aviatesk
force-pushed
the
jn/invert-line-table
branch
from
46bb524 to
96020bd
Compare
aviatesk
force-pushed
the
jn/invert-line-table
branch
2 times, most recently
from
bfe840f to
f99d97c
Compare
|
TypedSyntax test is failing badly... |
aviatesk
force-pushed
the
jn/invert-line-table
branch
from
f99d97c to
3c3759e
Compare
|
I adjusted the TypedSyntax update so now the number of failing tests matches what we're seeing with v1.11-nightly. I'm going to push ahead with this as it stands to keep working on other packages. I aim to implement more conservative and safer changes in the near future. |
|
Ok, Cthulhu CI is green on nightly. I will go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains some updates needed to keep working with the optimized debuginfo format (JuliaLang/julia#52415).
Also needs JuliaDebug/JuliaInterpreter.jl#606