Minimal fix for change in CostCallInfo #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timholy
reviewed
Mar 12, 2021
Co-authored-by: Tim Holy <[email protected]>
|
Merging this so people won't have a broken Cthulhu experience, but we should revisit this since I don't think it's quite correct. |
Yeah I will look into this tmrw. |
aviatesk
added a commit
to aviatesk/Cthulhu.jl
that referenced
this pull request
Mar 14, 2021
… callsites I think this is the proper update to JuliaLang/julia#39305. We can use `ConstPropCallInfo` only for the successful constant-prop'ed result and just keep using the usual `MICallInfo` for successful one, because each of `ConstCallInfo.results` should correspond to each callsite obtained from `ConstCallInfo.call::Union{MethodMatchInfo,UnionSplitInfo}`. Basic tests are also added.
aviatesk
added a commit
that referenced
this pull request
Apr 2, 2021
follow up #137, remove duplicated non-constant callsites
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just the general fix to try and get tests to pass again and Cthulhu somewhat working, I don't think it's optimal, but it's also not clear to me how to tell from the new design of ConstCallInfo, what to do if the result is
nothing, i.e. what choices to present to the user there, so we may have to take another look at how this info is computed in Base. @aviatesk could you think about what needs to be done here?